Re: [PATCH] Core driver for WM97xx touchscreens

2008-02-12 Thread Mark Brown
On Mon, Feb 11, 2008 at 07:00:30PM -0500, Pete MacKay wrote: > In wm97xx-core.c, should > > +int wm97xx_resume(struct device *dev) > be static? > Also, should Yes, and in fact I had both fixes present in the development branch but had forgotten to cherry pick them over into the upstream branch

Re: [PATCH] Core driver for WM97xx touchscreens

2008-02-11 Thread Pete MacKay
In wm97xx-core.c, should > +int wm97xx_resume(struct device *dev) be static? Also, should > + if (wm->ts_use_count) { have been changed to > + if (wm->input_dev->users) { in this revised revision? (Oops, that was repetitively redundant. :) -- To unsubscribe from th

Re: [PATCH] Core driver for WM97xx touchscreens

2008-01-19 Thread Dmitry
Hi, 2008/1/20, Mark Brown <[EMAIL PROTECTED]>: > On Sat, Jan 19, 2008 at 10:48:32PM +0300, Dmitry wrote: > > > Well... It's a common suggestion not to duplicate code. The wm97xx bus > > looks mostly like platform. The only difference is the name. To help > > visualisation, devices can have parents

Re: [PATCH] Core driver for WM97xx touchscreens

2008-01-19 Thread Mark Brown
On Sat, Jan 19, 2008 at 10:48:32PM +0300, Dmitry wrote: > Well... It's a common suggestion not to duplicate code. The wm97xx bus > looks mostly like platform. The only difference is the name. To help > visualisation, devices can have parents. Just set (in pseudocode) > wm97xx-touchscreen->parent t

Re: [PATCH] Core driver for WM97xx touchscreens

2008-01-19 Thread Dmitry Baryshkov
Ben Dooks wrote: > On Fri, Jan 18, 2008 at 06:11:45PM +, Dmitry Baryshkov wrote: >> Hi, >> >> Dmitry Torokhov wrote: >> >> > I will need some more time to review and understand the need for the >> > new bus in the driver. >> >> Most likely this can be converted to platform_bus. Maybe this c

Re: [PATCH] Core driver for WM97xx touchscreens

2008-01-19 Thread Dmitry
Hi, 2008/1/19, Mark Brown <[EMAIL PROTECTED]>: > On Fri, Jan 18, 2008 at 06:11:45PM +, Dmitry Baryshkov wrote: > > Dmitry Torokhov wrote: > > > > I will need some more time to review and understand the need for the new > > > bus in the driver. > > > Most likely this can be converted to platfor

Re: [PATCH] Core driver for WM97xx touchscreens

2008-01-19 Thread Mark Brown
On Fri, Jan 18, 2008 at 06:11:45PM +, Dmitry Baryshkov wrote: > Dmitry Torokhov wrote: > > I will need some more time to review and understand the need for the new > > bus in the driver. > Most likely this can be converted to platform_bus. Maybe this can also get Could you expand on how you

Re: [PATCH] Core driver for WM97xx touchscreens

2008-01-18 Thread Ben Dooks
On Fri, Jan 18, 2008 at 06:11:45PM +, Dmitry Baryshkov wrote: > Hi, > > Dmitry Torokhov wrote: > > > I will need some more time to review and understand the need for the new > > bus in the driver. > > Most likely this can be converted to platform_bus. Maybe this can also get > help from soon

Re: [PATCH] Core driver for WM97xx touchscreens

2008-01-18 Thread Dmitry Baryshkov
Hi, Dmitry Torokhov wrote: > I will need some more time to review and understand the need for the new > bus in the driver. Most likely this can be converted to platform_bus. Maybe this can also get help from soon-to-be posted MFD (multi function devices) helpers. -- With best wishes Dmitry -

Re: [PATCH] Core driver for WM97xx touchscreens

2008-01-18 Thread Dmitry Torokhov
Hi Mark, On Fri, Jan 18, 2008 at 04:27:06PM +, Mark Brown wrote: > This patch series adds support for the touchscreen controllers provided > by Wolfson Microelectronics WM97xx series chips in both polled and > streaming modes. > Thank you for the patches. Some comments below. > +static int w