Re: [PATCH] Change request_irq() to use struct net_device *dev->name

2013-07-27 Thread Sergei Shtylyov
On 27-07-2013 12:58, Prashant Shah wrote: It's also called managed device API. In fact, I've never heard it named devres API. If I understood it correctly it has to just calls devm_request_region() with the struct device pointer and there are no deallocation functions to call ? It manages

Re: [PATCH] Change request_irq() to use struct net_device *dev->name

2013-07-27 Thread Prashant Shah
Hi, On Fri, Jul 26, 2013 at 12:08 AM, Aaro Koskinen wrote: > Hi, > > On Thu, Jul 25, 2013 at 10:33:24PM +0400, Sergei Shtylyov wrote: >>It's also called managed device API. In fact, I've never heard it >> named devres API. If I understood it correctly it has to just calls devm_request_region

Re: [PATCH] Change request_irq() to use struct net_device *dev->name

2013-07-25 Thread Aaro Koskinen
Hi, On Thu, Jul 25, 2013 at 10:33:24PM +0400, Sergei Shtylyov wrote: >It's also called managed device API. In fact, I've never heard it > named devres API. Never read the documentation. :-) $ head -1 Documentation/driver-model/devres.txt Devres - Managed Device Resource A. -- To unsubscrib

Re: [PATCH] Change request_irq() to use struct net_device *dev->name

2013-07-25 Thread Sergei Shtylyov
Hello. On 07/25/2013 10:31 PM, Andy Shevchenko wrote: Andy, I can't find a single example of a devres_* call in drivers/net/ethernet/*. Does any networking code exist that we can look at as an example for conversion to the devres API? devres API usually means managed version of the functi

Re: [PATCH] Change request_irq() to use struct net_device *dev->name

2013-07-25 Thread Andy Shevchenko
On Thu, Jul 25, 2013 at 6:20 PM, tedheadster wrote: > Andy, > I can't find a single example of a devres_* call in > drivers/net/ethernet/*. Does any networking code exist that we can look at > as an example for conversion to the devres API? devres API usually means managed version of the functi

Re: [PATCH] Change request_irq() to use struct net_device *dev->name

2013-07-25 Thread Andy Shevchenko
On Thu, Jul 25, 2013 at 8:38 AM, Prashant Shah wrote: > On Thu, Jul 25, 2013 at 10:49 AM, Prashant Shah > wrote: >>> You should also remove the definition of DRV_NAME, since it is no longer >>> used. The changelog should probably mention that this will change the >>> interrupt name (which appear

Re: [PATCH] Change request_irq() to use struct net_device *dev->name

2013-07-24 Thread Prashant Shah
Hi, On Thu, Jul 25, 2013 at 10:49 AM, Prashant Shah wrote: > Hi, > >> You should also remove the definition of DRV_NAME, since it is no longer >> used. The changelog should probably mention that this will change the >> interrupt name (which appears in /proc/interrupts for example) from "wd" >> to

Re: [PATCH] Change request_irq() to use struct net_device *dev->name

2013-07-24 Thread Prashant Shah
Hi, > You should also remove the definition of DRV_NAME, since it is no longer > used. The changelog should probably mention that this will change the > interrupt name (which appears in /proc/interrupts for example) from "wd" > to "eth%d". > I will resend the patch. Regards. -- To unsubscribe fr

Re: [PATCH] Change request_irq() to use struct net_device *dev->name

2013-07-24 Thread Ryan Mallon
On 24/07/13 16:09, Prashant Shah wrote: > Signed-off-by: Prashant Shah > --- > drivers/net/ethernet/8390/wd.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/8390/wd.c b/drivers/net/ethernet/8390/wd.c > index 03eb3ee..b43a63f 100644 > --- a/driver