Re: [PATCH] Add support for getting and setting SACLs

2020-12-07 Thread Boris Protopopov
HI, Pavel, yes, thanks for the pointer, will include in the future. Boris. On Mon, Dec 7, 2020 at 2:05 PM Pavel Shilovsky wrote: > > Hi Boris, > > Are you talking about this patch "[PATCH] Extend cifs acl utilities to > handle SACLs"? > > Just for the future, I am trying to monitor the samba-de

Re: [PATCH] Add support for getting and setting SACLs

2020-12-07 Thread Pavel Shilovsky
Hi Boris, Are you talking about this patch "[PATCH] Extend cifs acl utilities to handle SACLs"? Just for the future, I am trying to monitor the samba-dev mailing list but if you would like to get the fastest response to your patches then please include me directly or at least the linux-cifs maili

Re: [PATCH] Add support for getting and setting SACLs

2020-12-07 Thread Boris Protopopov
Hello, Shyam, sorry for the delayed reply and thanks for looking at this patch. Yes, the testing was done using the extended versions of getcifsacl/setcifsacl (added setting owner and SACL support), the patch for that posted recently via samba-technical (message ID <20201120214918.12517-1-pbo...@a

Re: [PATCH] Add support for getting and setting SACLs

2020-12-02 Thread Shyam Prasad N
Hi Boris, At a high level, the changes look good to me. Will go through the changes in more detail tomorrow morning. On a related note, we may need more test coverage in this area. Can you please share your testing output against your changes? Or even better, if you can contribute some xfstests f

Re: [PATCH] Add support for getting and setting SACLs

2020-12-01 Thread Boris Protopopov
Hello, I am checking in to see if anyone had a chance to take a look at this patch. I would appreciate any feedback. Thanks! On Tue, Oct 27, 2020 at 5:01 PM Boris Protopopov via samba-technical wrote: > > Add SYSTEM_SECURITY access flag and use with smb2 when opening > files for getting/setting S