RE: [PATCH] Add file permission mode helpers ( [PATCH xxxx/1285] Replace numeric parameter like 0444 with macro)

2016-08-04 Thread Ni, BaoleX
x27;Sagi Grimberg'; 'Takashi Sakamoto'; 'Peter Ujfalusi'; 'Radim Krcmár'; 'Guenter Roeck'; 'matwey.korni...@gmail.com'; 'One Thousand Gnomes'; 'Roger Pau Monné'; 'Conor O'Gorman'; 'Laurence Oberman&#

Re: [PATCH] Add file permission mode helpers

2016-08-03 Thread Pavel Machek
On Wed 2016-08-03 10:11:40, Ingo Molnar wrote: > > * Linus Torvalds wrote: > > > [ So I answered similarly to another patch, but I'll just re-iterate > > and change the subject line so that it stands out a bit from the > > millions of actual patches ] > > > > On Tue, Aug 2, 2016 at 1:42 PM, Pav

Re: [PATCH] Add file permission mode helpers

2016-08-03 Thread Joe Perches
On Wed, 2016-08-03 at 10:11 +0200, Ingo Molnar wrote: > * Linus Torvalds wrote: > > [ So I answered similarly to another patch, but I'll just re-iterate > > and change the subject line so that it stands out a bit from the > > millions of actual patches ] > > > > On Tue, Aug 2, 2016 at 1:42 PM, Pa

Re: [PATCH] Add file permission mode helpers

2016-08-03 Thread Marcel Holtmann
Hi Greg, >> An added advantage would be that during review it would stick out like a >> sore >> thumb if anyone used a 'weird' permission variant. >> >> For example, if you saw these lines in a driver patch: >> >> +__ATTR(l1, 0444, driver_show_l4, NULL); >> +__ATTR(l3, 0446, dr

Re: [PATCH] Add file permission mode helpers

2016-08-03 Thread Willy Tarreau
On Wed, Aug 03, 2016 at 10:39:03AM +0200, Ingo Molnar wrote: > > > While the weird permissions in this: > > > > > > + __ATTR(l1, PERM_r__r__r__, driver_show_l4, NULL); > > > + __ATTR(l3, PERM_r__r__rw_, driver_show_l4, NULL); > > > + __ATTR(l2, PERM_sr__r__r__, driver_sho

Re: [PATCH] Add file permission mode helpers

2016-08-03 Thread Ingo Molnar
* Greg Kroah-Hartman wrote: > On Wed, Aug 03, 2016 at 10:11:40AM +0200, Ingo Molnar wrote: > > An added advantage would be that during review it would stick out like a > > sore > > thumb if anyone used a 'weird' permission variant. > > > > For example, if you saw these lines in a driver patch

Re: [PATCH] Add file permission mode helpers

2016-08-03 Thread Greg Kroah-Hartman
On Wed, Aug 03, 2016 at 10:11:40AM +0200, Ingo Molnar wrote: > An added advantage would be that during review it would stick out like a sore > thumb if anyone used a 'weird' permission variant. > > For example, if you saw these lines in a driver patch: > > + __ATTR(l1, 0444, driver_show_l4,