Re: [PATCH] ASoC: tegra: Convert to managed resources

2015-08-18 Thread Vaishali Thakkar
On Tue, Aug 18, 2015 at 12:48 PM, Alexandre Courbot wrote: > On Mon, Aug 17, 2015 at 6:32 PM, Vaishali Thakkar > wrote: >> On Mon, Aug 17, 2015 at 12:47 PM, Alexandre Courbot wrote: >>> On Thu, Aug 13, 2015 at 4:29 PM, Vaishali Thakkar >>> wrote: Use managed resource functions devm_clk_put

Re: [PATCH] ASoC: tegra: Convert to managed resources

2015-08-18 Thread Alexandre Courbot
On Mon, Aug 17, 2015 at 6:32 PM, Vaishali Thakkar wrote: > On Mon, Aug 17, 2015 at 12:47 PM, Alexandre Courbot wrote: >> On Thu, Aug 13, 2015 at 4:29 PM, Vaishali Thakkar >> wrote: >>> Use managed resource functions devm_clk_put and >>> devm_snd_soc_register_component to simplify error handling.

Re: [PATCH] ASoC: tegra: Convert to managed resources

2015-08-17 Thread Mark Brown
On Tue, Aug 18, 2015 at 08:15:35AM +0530, Vaishali Thakkar wrote: > I think yes may be code was good before this. But devm_clk_put part should > work > fine as call of it is before PM stuff. So, can I send a patch > reverting the change > of component part or do you want me to send a patch revert

Re: [PATCH] ASoC: tegra: Convert to managed resources

2015-08-17 Thread Vaishali Thakkar
On Tue, Aug 18, 2015 at 2:17 AM, Mark Brown wrote: > On Mon, Aug 17, 2015 at 03:02:29PM +0530, Vaishali Thakkar wrote: > >> I think you are right. I missed that. But now thing is , this patch is >> already >> applied here: >> https://git.kernel.org/cgit/linux/kernel/git/broonie/sound.git/commit/?

Re: [PATCH] ASoC: tegra: Convert to managed resources

2015-08-17 Thread Mark Brown
On Mon, Aug 17, 2015 at 03:02:29PM +0530, Vaishali Thakkar wrote: > I think you are right. I missed that. But now thing is , this patch is already > applied here: > https://git.kernel.org/cgit/linux/kernel/git/broonie/sound.git/commit/?h=topic/tegra > I am not sure if now I can change version 2 w

Re: [PATCH] ASoC: tegra: Convert to managed resources

2015-08-17 Thread Vaishali Thakkar
On Mon, Aug 17, 2015 at 12:47 PM, Alexandre Courbot wrote: > On Thu, Aug 13, 2015 at 4:29 PM, Vaishali Thakkar > wrote: >> Use managed resource functions devm_clk_put and >> devm_snd_soc_register_component to simplify error handling. >> >> To be compatible with the change various gotos are replac

Re: [PATCH] ASoC: tegra: Convert to managed resources

2015-08-17 Thread Alexandre Courbot
On Thu, Aug 13, 2015 at 4:29 PM, Vaishali Thakkar wrote: > Use managed resource functions devm_clk_put and > devm_snd_soc_register_component to simplify error handling. > > To be compatible with the change various gotos are replaced > with direct returns, and unneeded labels are dropped. > > Signe