Re: [PATCH] ASoC: simple-card: Fix refcount underflow

2019-02-18 Thread Mark Brown
On Mon, Feb 18, 2019 at 08:52:26AM +0100, Takashi Iwai wrote: > Daniel Baluta wrote: > > > Fixes: commit da215354eb55c ("ASoC: simple-card: merge simple-scu- > > > card") > > Thanks! I thought about adding this but the current patch will not > > cleanly apply because of: > > 2d01a84605a55c ("ASo

Re: [PATCH] ASoC: simple-card: Fix refcount underflow

2019-02-17 Thread Takashi Iwai
On Mon, 18 Feb 2019 08:06:19 +0100, Daniel Baluta wrote: > > On Mon, 2019-02-18 at 10:37 +0900, Kuninori Morimoto wrote: > > Hi Daniel, Mark, again > > > > > > of_get_child_by_name() takes a reference we'll need to drop > > > > later so when we substitute in top we need to take a reference > > >

Re: [PATCH] ASoC: simple-card: Fix refcount underflow

2019-02-17 Thread Daniel Baluta
On Mon, 2019-02-18 at 10:37 +0900, Kuninori Morimoto wrote: > Hi Daniel, Mark, again > > > > of_get_child_by_name() takes a reference we'll need to drop > > > later so when we substitute in top we need to take a reference > > > as well as just assigning. > > > > > > Without this patch we hit the

Re: [PATCH] ASoC: simple-card: Fix refcount underflow

2019-02-17 Thread Kuninori Morimoto
Hi Daniel, Mark, again > > of_get_child_by_name() takes a reference we'll need to drop > > later so when we substitute in top we need to take a reference > > as well as just assigning. > > > > Without this patch we hit the following error: > > > > [1.246852] OF: ERROR: Bad of_node_put() on

Re: [PATCH] ASoC: simple-card: Fix refcount underflow

2019-02-17 Thread Kuninori Morimoto
Hi Daniel, Mark > of_get_child_by_name() takes a reference we'll need to drop > later so when we substitute in top we need to take a reference > as well as just assigning. > > Without this patch we hit the following error: > > [1.246852] OF: ERROR: Bad of_node_put() on /sound-wm8524 > [