Re: [PATCH] ASoC: cros_ec_codec: fix uninitialized memory read

2020-12-04 Thread Mark Brown
On Thu, 3 Dec 2020 23:54:41 +0100, Arnd Bergmann wrote: > gcc points out a memory area that is copied to a device > but not initialized: > > sound/soc/codecs/cros_ec_codec.c: In function 'i2s_rx_event': > arch/x86/include/asm/string_32.h:83:20: error: '*((void *)&p+4)' may be used > uninitialized

Re: [PATCH] ASoC: cros_ec_codec: fix uninitialized memory read

2020-12-04 Thread Tzung-Bi Shih
On Fri, Dec 4, 2020 at 4:28 PM Arnd Bergmann wrote: > > On Fri, Dec 4, 2020 at 3:56 AM Tzung-Bi Shih wrote: > > > > On Fri, Dec 4, 2020 at 6:55 AM Arnd Bergmann wrote: > > > > In the case in i2s_rx_event(), only the "cmd" member is used. But it > > is fine to please the compiler. > > I wouldn't

Re: [PATCH] ASoC: cros_ec_codec: fix uninitialized memory read

2020-12-04 Thread Arnd Bergmann
On Fri, Dec 4, 2020 at 3:56 AM Tzung-Bi Shih wrote: > > On Fri, Dec 4, 2020 at 6:55 AM Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > gcc points out a memory area that is copied to a device > > but not initialized: > > > > sound/soc/codecs/cros_ec_codec.c: In function 'i2s_rx_event': >

Re: [PATCH] ASoC: cros_ec_codec: fix uninitialized memory read

2020-12-03 Thread Tzung-Bi Shih
On Fri, Dec 4, 2020 at 6:55 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > gcc points out a memory area that is copied to a device > but not initialized: > > sound/soc/codecs/cros_ec_codec.c: In function 'i2s_rx_event': > arch/x86/include/asm/string_32.h:83:20: error: '*((void *)&p+4)' may b