On Fri, Feb 2, 2018 at 5:06 PM, Mark Brown wrote:
> On Thu, Feb 01, 2018 at 04:46:56PM +0200, Andy Shevchenko wrote:
>> On Thu, Feb 1, 2018 at 3:48 PM, Mark Brown wrote:
>
>> >> >> > Signed-off-by: Junichi Wakasugi
>> >> >> > Signed-off-by: Mihai Serban
>> >> >> > Signed-off-by: Shengjiu Wang
On Thu, Feb 01, 2018 at 04:46:56PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 1, 2018 at 3:48 PM, Mark Brown wrote:
> >> >> > Signed-off-by: Junichi Wakasugi
> >> >> > Signed-off-by: Mihai Serban
> >> >> > Signed-off-by: Shengjiu Wang
> >> >> > Signed-off-by: Daniel Baluta
> > Honestly the
On Thu, Feb 1, 2018 at 3:48 PM, Mark Brown wrote:
> On Thu, Feb 01, 2018 at 03:20:38PM +0200, Andy Shevchenko wrote:
>> On Thu, Feb 1, 2018 at 11:05 AM, Daniel Baluta wrote:
>
>> >> > Signed-off-by: Junichi Wakasugi
>> >> > Signed-off-by: Mihai Serban
>> >> > Signed-off-by: Shengjiu Wang
>> >>
On Thu, Feb 01, 2018 at 03:20:38PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 1, 2018 at 11:05 AM, Daniel Baluta wrote:
> >> > Signed-off-by: Junichi Wakasugi
> >> > Signed-off-by: Mihai Serban
> >> > Signed-off-by: Shengjiu Wang
> >> > Signed-off-by: Daniel Baluta
> >> 4 authors of the code
On Thu, Feb 1, 2018 at 11:05 AM, Daniel Baluta wrote:
>> > Signed-off-by: Junichi Wakasugi
>> > Signed-off-by: Mihai Serban
>> > Signed-off-by: Shengjiu Wang
>> > Signed-off-by: Daniel Baluta
>> 4 authors of the code?!
>
> The code has a very long history. I will add under each SoB the specif
Hi Fabio, Andy,
Thanks a lot for your comments. I will address them and send v2.
Few comments inline.
On Mi, 2018-01-31 at 18:12 +0200, Andy Shevchenko wrote:
> On Wed, Jan 31, 2018 at 2:57 PM, Daniel Baluta wrote:
> >
> > AK5558 is a 32-bit, 768 kHZ sampling, differential input ADC
> > for di
On Wed, Jan 31, 2018 at 02:20:31PM -0200, Fabio Estevam wrote:
> On Wed, Jan 31, 2018 at 10:57 AM, Daniel Baluta wrote:
> > + dev_err(&i2c->dev, "%s(%d)\n", __func__, __LINE__);
> You certainly do not want an error message on every probe :-)
Sometimes you've just got to be honest with peo
On Wed, Jan 31, 2018 at 6:20 PM, Fabio Estevam wrote:
> Hi Daniel,
Fabio, +1 to your review. It seems it repeats some of the points I made.
>> + ak5558->pdn_gpio = of_get_named_gpio(np, "ak5558,pdn-gpio", 0);
>
> It does not match the property in the binding doc: asahi-kasei,pdn-gpios
Bt
Hi Daniel,
On Wed, Jan 31, 2018 at 10:57 AM, Daniel Baluta wrote:
> AK5558 is a 32-bit, 768 kHZ sampling, differential input ADC
> for digital audio systems.
>
> Datasheet is available at:
>
> https://www.akm.com/akm/en/file/datasheet/AK5558VN.pdf
>
> Initial patch includes support for normal and
On Wed, Jan 31, 2018 at 2:57 PM, Daniel Baluta wrote:
> AK5558 is a 32-bit, 768 kHZ sampling, differential input ADC
> for digital audio systems.
>
> Datasheet is available at:
>
> https://www.akm.com/akm/en/file/datasheet/AK5558VN.pdf
>
> Initial patch includes support for normal and TDM modes.
>
10 matches
Mail list logo
