Re: [PATCH] ARM: Fix zImage file size not aligned with CONFIG_EFI_STUB enabled

2017-10-24 Thread Ard Biesheuvel
On 24 October 2017 at 10:54, Russell King - ARM Linux wrote: > On Tue, Oct 24, 2017 at 10:44:00AM +0100, Ard Biesheuvel wrote: >> On 24 October 2017 at 10:38, Russell King - ARM Linux >> wrote: >> > Do you have any preference - I'd prefer one that I can merge along with >> > these changes? One w

Re: [PATCH] ARM: Fix zImage file size not aligned with CONFIG_EFI_STUB enabled

2017-10-24 Thread Russell King - ARM Linux
On Tue, Oct 24, 2017 at 10:44:00AM +0100, Ard Biesheuvel wrote: > On 24 October 2017 at 10:38, Russell King - ARM Linux > wrote: > > Do you have any preference - I'd prefer one that I can merge along with > > these changes? One way forward would be to temporarily add the /DISCARD/ > > for the ksy

Re: [PATCH] ARM: Fix zImage file size not aligned with CONFIG_EFI_STUB enabled

2017-10-24 Thread Ard Biesheuvel
On 24 October 2017 at 10:38, Russell King - ARM Linux wrote: > On Tue, Oct 24, 2017 at 10:30:41AM +0100, Ard Biesheuvel wrote: >> On 24 October 2017 at 10:26, Ard Biesheuvel >> wrote: >> > On 24 October 2017 at 10:22, Russell King - ARM Linux >> > wrote: >> >> On Tue, Oct 24, 2017 at 10:13:09AM

Re: [PATCH] ARM: Fix zImage file size not aligned with CONFIG_EFI_STUB enabled

2017-10-24 Thread Russell King - ARM Linux
On Tue, Oct 24, 2017 at 10:30:41AM +0100, Ard Biesheuvel wrote: > On 24 October 2017 at 10:26, Ard Biesheuvel wrote: > > On 24 October 2017 at 10:22, Russell King - ARM Linux > > wrote: > >> On Tue, Oct 24, 2017 at 10:13:09AM +0100, Ard Biesheuvel wrote: > >>> On 24 October 2017 at 10:09, Russell

Re: [PATCH] ARM: Fix zImage file size not aligned with CONFIG_EFI_STUB enabled

2017-10-24 Thread Ard Biesheuvel
On 24 October 2017 at 10:26, Ard Biesheuvel wrote: > On 24 October 2017 at 10:22, Russell King - ARM Linux > wrote: >> On Tue, Oct 24, 2017 at 10:13:09AM +0100, Ard Biesheuvel wrote: >>> On 24 October 2017 at 10:09, Russell King - ARM Linux >>> wrote: >>> > The question is: do we want to know wh

Re: [PATCH] ARM: Fix zImage file size not aligned with CONFIG_EFI_STUB enabled

2017-10-24 Thread Ard Biesheuvel
On 24 October 2017 at 10:22, Russell King - ARM Linux wrote: > On Tue, Oct 24, 2017 at 10:13:09AM +0100, Ard Biesheuvel wrote: >> On 24 October 2017 at 10:09, Russell King - ARM Linux >> wrote: >> > The question is: do we want to know when additional sections get >> > emitted into the binary? >>

Re: [PATCH] ARM: Fix zImage file size not aligned with CONFIG_EFI_STUB enabled

2017-10-24 Thread Russell King - ARM Linux
On Tue, Oct 24, 2017 at 10:13:09AM +0100, Ard Biesheuvel wrote: > On 24 October 2017 at 10:09, Russell King - ARM Linux > wrote: > > The question is: do we want to know when additional sections get > > emitted into the binary? > > Well, we need to know whether the size of zImage is a multiple of

Re: [PATCH] ARM: Fix zImage file size not aligned with CONFIG_EFI_STUB enabled

2017-10-24 Thread jeffy
Hi guys, On 10/24/2017 04:09 PM, Ard Biesheuvel wrote: The following patch appears to fix the issue as well: diff --git a/arch/arm/boot/compressed/vmlinux.lds.S b/arch/arm/boot/compressed/vmlinux.lds.S index 7a4c59154361..0e0f504e256e 100644 --- a/arch/arm/boot/compressed/vmlinux.lds.S +++ b/ar

Re: [PATCH] ARM: Fix zImage file size not aligned with CONFIG_EFI_STUB enabled

2017-10-24 Thread Ard Biesheuvel
On 24 October 2017 at 10:09, Russell King - ARM Linux wrote: > On Tue, Oct 24, 2017 at 09:09:52AM +0100, Ard Biesheuvel wrote: >> The following patch appears to fix the issue as well: >> >> diff --git a/arch/arm/boot/compressed/vmlinux.lds.S >> b/arch/arm/boot/compressed/vmlinux.lds.S >> index 7a4

Re: [PATCH] ARM: Fix zImage file size not aligned with CONFIG_EFI_STUB enabled

2017-10-24 Thread Russell King - ARM Linux
On Tue, Oct 24, 2017 at 09:09:52AM +0100, Ard Biesheuvel wrote: > The following patch appears to fix the issue as well: > > diff --git a/arch/arm/boot/compressed/vmlinux.lds.S > b/arch/arm/boot/compressed/vmlinux.lds.S > index 7a4c59154361..0e0f504e256e 100644 > --- a/arch/arm/boot/compressed/vmli

Re: [PATCH] ARM: Fix zImage file size not aligned with CONFIG_EFI_STUB enabled

2017-10-24 Thread Ard Biesheuvel
On 23 October 2017 at 12:45, Russell King - ARM Linux wrote: > On Mon, Oct 23, 2017 at 11:50:46AM +0100, Russell King - ARM Linux wrote: >> On Mon, Oct 23, 2017 at 06:24:12PM +0800, jeffy wrote: >> > Hi Russell, >> > >> > Thanks for your reply. >> > >> > On 10/23/2017 04:50 PM, Russell King - ARM

Re: [PATCH] ARM: Fix zImage file size not aligned with CONFIG_EFI_STUB enabled

2017-10-23 Thread Russell King - ARM Linux
On Mon, Oct 23, 2017 at 11:50:46AM +0100, Russell King - ARM Linux wrote: > On Mon, Oct 23, 2017 at 06:24:12PM +0800, jeffy wrote: > > Hi Russell, > > > > Thanks for your reply. > > > > On 10/23/2017 04:50 PM, Russell King - ARM Linux wrote: > > >>> > > >>>hmm, right, didn't notice the data is al

Re: [PATCH] ARM: Fix zImage file size not aligned with CONFIG_EFI_STUB enabled

2017-10-23 Thread Russell King - ARM Linux
On Mon, Oct 23, 2017 at 06:24:12PM +0800, jeffy wrote: > Hi Russell, > > Thanks for your reply. > > On 10/23/2017 04:50 PM, Russell King - ARM Linux wrote: > >>> > >>>hmm, right, didn't notice the data is already aligned... > >>>so it's indeed caused by the ksym: > >>> > >>> [ 9] .data

Re: [PATCH] ARM: Fix zImage file size not aligned with CONFIG_EFI_STUB enabled

2017-10-23 Thread jeffy
Hi Russell, Thanks for your reply. On 10/23/2017 04:50 PM, Russell King - ARM Linux wrote: > >hmm, right, didn't notice the data is already aligned... >so it's indeed caused by the ksym: > > [ 9] .data PROGBITS006ce000 6d6000 000200 00 WA 0 >0 4096 > [10] ___ksymtab+so

Re: [PATCH] ARM: Fix zImage file size not aligned with CONFIG_EFI_STUB enabled

2017-10-23 Thread Russell King - ARM Linux
On Mon, Oct 23, 2017 at 11:26:49AM +0800, jeffy wrote: > Hi Ard, > > On 10/22/2017 09:01 PM, Ard Biesheuvel wrote: > >On 22 October 2017 at 13:47, Russell King - ARM Linux > > wrote: > >>On Sun, Oct 22, 2017 at 12:01:13PM +0100, Ard Biesheuvel wrote: > >>>On 18 October 2017 at 06:01, Jeffy Chen w

Re: [PATCH] ARM: Fix zImage file size not aligned with CONFIG_EFI_STUB enabled

2017-10-22 Thread jeffy
Hi Ard, On 10/22/2017 09:01 PM, Ard Biesheuvel wrote: On 22 October 2017 at 13:47, Russell King - ARM Linux wrote: On Sun, Oct 22, 2017 at 12:01:13PM +0100, Ard Biesheuvel wrote: On 18 October 2017 at 06:01, Jeffy Chen wrote: The zImage file size should be aligned. Fixes: e4bae4d0b5f3 ("ar

Re: [PATCH] ARM: Fix zImage file size not aligned with CONFIG_EFI_STUB enabled

2017-10-22 Thread Ard Biesheuvel
On 22 October 2017 at 13:47, Russell King - ARM Linux wrote: > On Sun, Oct 22, 2017 at 12:01:13PM +0100, Ard Biesheuvel wrote: >> On 18 October 2017 at 06:01, Jeffy Chen wrote: >> > The zImage file size should be aligned. >> > >> > Fixes: e4bae4d0b5f3 ("arm/efi: Split zImage code and data into se

Re: [PATCH] ARM: Fix zImage file size not aligned with CONFIG_EFI_STUB enabled

2017-10-22 Thread Russell King - ARM Linux
On Sun, Oct 22, 2017 at 12:01:13PM +0100, Ard Biesheuvel wrote: > On 18 October 2017 at 06:01, Jeffy Chen wrote: > > The zImage file size should be aligned. > > > > Fixes: e4bae4d0b5f3 ("arm/efi: Split zImage code and data into separate > > PE/COFF sections") > > Signed-off-by: Jeffy Chen > > --

Re: [PATCH] ARM: Fix zImage file size not aligned with CONFIG_EFI_STUB enabled

2017-10-22 Thread Ard Biesheuvel
On 18 October 2017 at 06:01, Jeffy Chen wrote: > The zImage file size should be aligned. > > Fixes: e4bae4d0b5f3 ("arm/efi: Split zImage code and data into separate > PE/COFF sections") > Signed-off-by: Jeffy Chen > --- > > arch/arm/boot/compressed/vmlinux.lds.S | 8 > 1 file changed,

Re: [PATCH] ARM: Fix zImage file size not aligned with CONFIG_EFI_STUB enabled

2017-10-17 Thread Chris Zhong
Tested-by: Chris Zhong On Wednesday, October 18, 2017 01:01 PM, Jeffy Chen wrote: The zImage file size should be aligned. Fixes: e4bae4d0b5f3 ("arm/efi: Split zImage code and data into separate PE/COFF sections") Signed-off-by: Jeffy Chen --- arch/arm/boot/compressed/vmlinux.lds.S | 8 ++