Re: [PATCH] ACPI: Add GPIO-signaled event emulator.

2014-08-29 Thread Rafael J. Wysocki
On Thursday, August 28, 2014 01:19:48 PM Tomasz Nowicki wrote: > On 26.08.2014 00:39, Rafael J. Wysocki wrote: > > On Thursday, August 21, 2014 04:39:46 PM Tomasz Nowicki wrote: > >> Hi Mika, > >> > >> On 21.08.2014 12:45, Mika Westerberg wrote: > >>> On Wed, Aug 20, 2014 at 04:58:20PM +0200, Tomas

Re: [PATCH] ACPI: Add GPIO-signaled event emulator.

2014-08-28 Thread Tomasz Nowicki
On 26.08.2014 00:39, Rafael J. Wysocki wrote: On Thursday, August 21, 2014 04:39:46 PM Tomasz Nowicki wrote: Hi Mika, On 21.08.2014 12:45, Mika Westerberg wrote: On Wed, Aug 20, 2014 at 04:58:20PM +0200, Tomasz Nowicki wrote: [cut] + +static int gpio_evt_trigger(void *data, u64 val) +{ +

Re: [PATCH] ACPI: Add GPIO-signaled event emulator.

2014-08-25 Thread Rafael J. Wysocki
On Thursday, August 21, 2014 04:39:46 PM Tomasz Nowicki wrote: > Hi Mika, > > On 21.08.2014 12:45, Mika Westerberg wrote: > > On Wed, Aug 20, 2014 at 04:58:20PM +0200, Tomasz Nowicki wrote: [cut] > >> + > >> +static int gpio_evt_trigger(void *data, u64 val) > >> +{ > >> + struct gpio_pin_data *

Re: [PATCH] ACPI: Add GPIO-signaled event emulator.

2014-08-21 Thread Tomasz Nowicki
On 21.08.2014 16:54, Mika Westerberg wrote: On Thu, Aug 21, 2014 at 04:39:46PM +0200, Tomasz Nowicki wrote: +{ + struct gpio_pin_data *pin_data, *temp; + + list_for_each_entry_safe(pin_data, temp, &pin_data_list, list) + kfree(pin_data); I suppose you want to first re

Re: [PATCH] ACPI: Add GPIO-signaled event emulator.

2014-08-21 Thread Mika Westerberg
On Thu, Aug 21, 2014 at 04:39:46PM +0200, Tomasz Nowicki wrote: > >>+{ > >>+ struct gpio_pin_data *pin_data, *temp; > >>+ > >>+ list_for_each_entry_safe(pin_data, temp, &pin_data_list, list) > >>+ kfree(pin_data); > > > >I suppose you want to first remove the directory entries and the

Re: [PATCH] ACPI: Add GPIO-signaled event emulator.

2014-08-21 Thread Tomasz Nowicki
Hi Mika, On 21.08.2014 12:45, Mika Westerberg wrote: On Wed, Aug 20, 2014 at 04:58:20PM +0200, Tomasz Nowicki wrote: GPIO-signaled events is quite new thing in Linux kernel. There are not many board which can take advantage of it. However, GPIO events are very useful feature during work on ACPI

Re: [PATCH] ACPI: Add GPIO-signaled event emulator.

2014-08-21 Thread Mika Westerberg
On Wed, Aug 20, 2014 at 04:58:20PM +0200, Tomasz Nowicki wrote: > GPIO-signaled events is quite new thing in Linux kernel. > There are not many board which can take advantage of it. > However, GPIO events are very useful feature during work on ACPI > subsystems. > > This commit emulates GPIO h/w b