Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-30 Thread Randy Dunlap
On Sun, 30 Sep 2007 13:40:13 -0400 Mark Lord wrote: > Erez Zadok wrote: > > In message <[EMAIL PROTECTED]>, Linus Torvalds writes: > >> > >> On Sat, 29 Sep 2007, Erez Zadok wrote: > >>> Would you prefer if CodingStyle was reorganized or even split into (1) > >>> general principles and (2) details?

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-30 Thread Theodore Tso
On Sat, Sep 29, 2007 at 11:29:33PM -0400, [EMAIL PROTECTED] wrote: > On Sat, 29 Sep 2007 20:00:01 PDT, Linus Torvalds said: > > On Sat, 29 Sep 2007, [EMAIL PROTECTED] wrote: > > > I think there needs to be a "sense of fairness" attached here - > > > CodingStyle > > > should cover all the stuff mai

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-30 Thread Mark Lord
Erez Zadok wrote: In message <[EMAIL PROTECTED]>, Linus Torvalds writes: On Sat, 29 Sep 2007, Erez Zadok wrote: Would you prefer if CodingStyle was reorganized or even split into (1) general principles and (2) details? Perhaps we need a CodingStylePrinciples and a CodingStyleDetails? I'm cer

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Linus Torvalds writes: > > > On Sat, 29 Sep 2007, Erez Zadok wrote: > > > > Would you prefer if CodingStyle was reorganized or even split into (1) > > general principles and (2) details? Perhaps we need a CodingStylePrinciples > > and a CodingStyleDetails? > > I

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Valdis . Kletnieks
On Sun, 30 Sep 2007 04:27:24 BST, Al Viro said: > ... and no matter how many rules you put down, it's still possible to > write a code that will be awful stylistically while adhering to all of > them. Religiously. I've run into those sort of programmers. Unfortunately, there's no real cure for

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Linus Torvalds
On Sat, 29 Sep 2007, [EMAIL PROTECTED] wrote: > > I kind of meant the *maintainers* couldn't whine about things not in > CodingStyle ;) No, I understood you. I'm personally of the opinion that the automated style checking, and having detailed rules is always a mistake. It's *much* better t

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Valdis . Kletnieks
On Sat, 29 Sep 2007 20:00:01 PDT, Linus Torvalds said: > On Sat, 29 Sep 2007, [EMAIL PROTECTED] wrote: > > I think there needs to be a "sense of fairness" attached here - CodingStyle > > should cover all the stuff maintainers/reviewers are allowed to whinge > > about. > > No. > > People whine to

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Theodore Tso writes: > On Sat, Sep 29, 2007 at 03:56:38PM -0400, J. Bruce Fields wrote: > > It'd be a start just to revert CodingStyle to its original content and > > move the rest to CodingStyleReference. But someone would want to skim > > through the CodingStyle h

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Al Viro
On Sat, Sep 29, 2007 at 10:24:01PM -0400, [EMAIL PROTECTED] wrote: > On Sat, 29 Sep 2007 11:18:05 PDT, Linus Torvalds said: > > > "CodingStyle" should be about the big issues, not about details. Yes, > > we've messed that up over the years, but let's not continue that. > > > > In other words, I'

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Linus Torvalds
On Sat, 29 Sep 2007, [EMAIL PROTECTED] wrote: > > I think there needs to be a "sense of fairness" attached here - CodingStyle > should cover all the stuff maintainers/reviewers are allowed to whinge about. No. People whine too much as is. Don't give them *license* to do so. Li

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Valdis . Kletnieks
On Sat, 29 Sep 2007 11:18:05 PDT, Linus Torvalds said: > "CodingStyle" should be about the big issues, not about details. Yes, > we've messed that up over the years, but let's not continue that. > > In other words, I'd suggest *removing* lines from CodingStyle, not adding > them. The file has a

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Theodore Tso
On Sat, Sep 29, 2007 at 03:56:38PM -0400, J. Bruce Fields wrote: > It'd be a start just to revert CodingStyle to its original content and > move the rest to CodingStyleReference. But someone would want to skim > through the CodingStyle history for any legimate corrections that we > want to keep.

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Linus Torvalds
On Sat, 29 Sep 2007, Erez Zadok wrote: > > Would you prefer if CodingStyle was reorganized or even split into (1) > general principles and (2) details? Perhaps we need a CodingStylePrinciples > and a CodingStyleDetails? I'm certainly ok with the split into two files. What I'm not ok with is r

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Linus Torvalds writes: > > > On Fri, 28 Sep 2007, Erez Zadok wrote: > > > > Documentation/CodingStyle | 88 > > +- > > I'm not very happy with this. > > "CodingStyle" should be about the big issues, not about detail

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Robert P. J. Day
On Sat, 29 Sep 2007, Linus Torvalds wrote: > > > On Fri, 28 Sep 2007, Erez Zadok wrote: > > > > Documentation/CodingStyle | 88 > > +- > > I'm not very happy with this. > > "CodingStyle" should be about the big issues, not about details. > Yes, we've

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Randy Dunlap
On Sat, 29 Sep 2007 15:56:38 -0400 J. Bruce Fields wrote: > On Sat, Sep 29, 2007 at 11:18:05AM -0700, Linus Torvalds wrote: > > I'm not very happy with this. > > > > "CodingStyle" should be about the big issues, not about details. Yes, > > we've messed that up over the years, but let's not conti

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread J. Bruce Fields
On Sat, Sep 29, 2007 at 11:18:05AM -0700, Linus Torvalds wrote: > I'm not very happy with this. > > "CodingStyle" should be about the big issues, not about details. Yes, > we've messed that up over the years, but let's not continue that. > > In other words, I'd suggest *removing* lines from Codi

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Linus Torvalds
On Fri, 28 Sep 2007, Erez Zadok wrote: > > Documentation/CodingStyle | 88 > +- I'm not very happy with this. "CodingStyle" should be about the big issues, not about details. Yes, we've messed that up over the years, but let's not continue that.