Re: [PATCH] [media] davinci-vpfe: Fix retcode check

2014-07-08 Thread Prabhakar Lad
Hi Andrey, Thanks for the patch! On Tue, Jul 8, 2014 at 3:58 PM, Andrey Utkin wrote: > 2014-07-08 17:32 GMT+03:00 Levente Kurusa : >> Hmm, while it is true that get_ipipe_mode returns an int, but >> the consequent call to regw_ip takes an u32 as its second >> argument. Did it cause a build warni

Re: [PATCH] [media] davinci-vpfe: Fix retcode check

2014-07-08 Thread Dan Carpenter
On Tue, Jul 08, 2014 at 04:32:57PM +0200, Levente Kurusa wrote: > 2014-07-08 16:08 GMT+02:00 Andrey Utkin : > > Use signed type to check correctly for negative error code. The issue > > was reported with static analyser: > > > > [linux-3.13/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c:270]:

Re: [PATCH] [media] davinci-vpfe: Fix retcode check

2014-07-08 Thread Andrey Utkin
2014-07-08 17:32 GMT+03:00 Levente Kurusa : > Hmm, while it is true that get_ipipe_mode returns an int, but > the consequent call to regw_ip takes an u32 as its second > argument. Did it cause a build warning for you? (Can't really > check since I don't have ARM cross compilers close-by) > If not,

Re: [PATCH] [media] davinci-vpfe: Fix retcode check

2014-07-08 Thread Levente Kurusa
2014-07-08 16:08 GMT+02:00 Andrey Utkin : > Use signed type to check correctly for negative error code. The issue > was reported with static analyser: > > [linux-3.13/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c:270]: > (style) A pointer can not be negative so it is either pointless or an >