Re: [PATCH] [5/12] x86_64: Make patching more robust, fix paravirt issue

2007-08-21 Thread Glauber de Oliveira Costa
On 8/21/07, Andi Kleen <[EMAIL PROTECTED]> wrote: > On Tue, Aug 21, 2007 at 04:30:10AM -0300, Glauber de Oliveira Costa wrote: > > On 8/20/07, Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > > Chris Wright wrote: > > > > That did get backed out (at least the part that broke paravirt patching) >

Re: [PATCH] [5/12] x86_64: Make patching more robust, fix paravirt issue

2007-08-21 Thread Andi Kleen
On Tue, Aug 21, 2007 at 04:30:10AM -0300, Glauber de Oliveira Costa wrote: > On 8/20/07, Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > Chris Wright wrote: > > > That did get backed out (at least the part that broke paravirt patching) > > > in 602033ed5907a59ce86f709082a35be047743a86. Linus' t

Re: [PATCH] [5/12] x86_64: Make patching more robust, fix paravirt issue

2007-08-21 Thread Glauber de Oliveira Costa
On 8/20/07, Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > Chris Wright wrote: > > That did get backed out (at least the part that broke paravirt patching) > > in 602033ed5907a59ce86f709082a35be047743a86. Linus' tree should be > > working fine right now with d34fda4a84c18402640a1a2342d6e6d9829e6

Re: [PATCH] [5/12] x86_64: Make patching more robust, fix paravirt issue

2007-08-19 Thread Jeremy Fitzhardinge
Chris Wright wrote: > That did get backed out (at least the part that broke paravirt patching) > in 602033ed5907a59ce86f709082a35be047743a86. Linus' tree should be > working fine right now with d34fda4a84c18402640a1a2342d6e6d9829e6db7 > committed, and can be further refined with the patch below th

Re: [PATCH] [5/12] x86_64: Make patching more robust, fix paravirt issue

2007-08-19 Thread Chris Wright
* Rusty Russell ([EMAIL PROTECTED]) wrote: > Then back out 19d36ccdc34f5ed444f8a6af0cbfdb6790eb1177 too, which broke > lguest booting, and this tried to fix. That did get backed out (at least the part that broke paravirt patching) in 602033ed5907a59ce86f709082a35be047743a86. Linus' tree should be

Re: [PATCH] [5/12] x86_64: Make patching more robust, fix paravirt issue

2007-08-19 Thread Rusty Russell
On Fri, 2007-08-17 at 17:05 -0700, Jeremy Fitzhardinge wrote: > Andi Kleen wrote: > > Commit 19d36ccdc34f5ed444f8a6af0cbfdb6790eb1177 "x86: Fix alternatives > > and kprobes to remap write-protected kernel text" uses code which is > > being patched for patching. > > > > In particular, paravirt_ops d

Re: [PATCH] [5/12] x86_64: Make patching more robust, fix paravirt issue

2007-08-18 Thread Jeremy Fitzhardinge
Andi Kleen wrote: >> This patch breaks Xen booting. >> > > Check the latest git head. Does it still break? Yes, that's with latest git head. J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] [5/12] x86_64: Make patching more robust, fix paravirt issue

2007-08-18 Thread Chris Wright
* Linus Torvalds ([EMAIL PROTECTED]) wrote: > On Sat, 18 Aug 2007, Chris Wright wrote: > > > > > > Check the latest git head. Does it still break? > > > > Yeah, this is the latest git. The broken commit is Rusty's patch which, > > after Linus reverted the write-protected remap changes, is no lon

Re: [PATCH] [5/12] x86_64: Make patching more robust, fix paravirt issue

2007-08-18 Thread Linus Torvalds
On Sat, 18 Aug 2007, Chris Wright wrote: > > > > Check the latest git head. Does it still break? > > Yeah, this is the latest git. The broken commit is Rusty's patch which, > after Linus reverted the write-protected remap changes, is no longer > necessary. AFAICT patching is writing garbage i

Re: [PATCH] [5/12] x86_64: Make patching more robust, fix paravirt issue

2007-08-18 Thread Chris Wright
* Andi Kleen ([EMAIL PROTECTED]) wrote: > > This patch breaks Xen booting. > > Check the latest git head. Does it still break? Yeah, this is the latest git. The broken commit is Rusty's patch which, after Linus reverted the write-protected remap changes, is no longer necessary. AFAICT patchin

Re: [PATCH] [5/12] x86_64: Make patching more robust, fix paravirt issue

2007-08-18 Thread Andi Kleen
> This patch breaks Xen booting. Check the latest git head. Does it still break? -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH] [5/12] x86_64: Make patching more robust, fix paravirt

2007-08-17 Thread sean a
git-bisect bad ab144f5ec64c42218a555ec1dbde6b60cf2982d6 Also breaks booting in VMWare's WS 6 if paravirtual support is enabled for the guest. Hope this helps narrow it down. Sean - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTE

Re: [PATCH] [5/12] x86_64: Make patching more robust, fix paravirt issue

2007-08-17 Thread Chris Wright
* Jeremy Fitzhardinge ([EMAIL PROTECTED]) wrote: > This patch breaks Xen booting. I get infinite recursive faults during > patching when this patch is present. If I boot with > "noreplace-paravirt" it works OK, and it works as expected if I back > this patch out. I haven't tracked down the exact

Re: [PATCH] [5/12] x86_64: Make patching more robust, fix paravirt issue

2007-08-17 Thread Jeremy Fitzhardinge
Andi Kleen wrote: > Commit 19d36ccdc34f5ed444f8a6af0cbfdb6790eb1177 "x86: Fix alternatives > and kprobes to remap write-protected kernel text" uses code which is > being patched for patching. > > In particular, paravirt_ops does patching in two stages: first it > calls paravirt_ops.patch, then it f