Re: [PATCH][v2] PM / Hibernate: Feed the wathdog when creating snapshot

2017-08-23 Thread Rafael J. Wysocki
On Wed, Aug 23, 2017 at 5:44 AM, Chen Yu wrote: > On Tue, Aug 22, 2017 at 02:55:39PM +0200, Rafael J. Wysocki wrote: >> On Tuesday, August 22, 2017 5:20:02 AM CEST Chen Yu wrote: >> > There is a problem that when counting the pages for creating >> > the hibernation snapshot will take significant a

Re: [PATCH][v2] PM / Hibernate: Feed the wathdog when creating snapshot

2017-08-23 Thread Michal Hocko
On Wed 23-08-17 11:44:39, Chen Yu wrote: > On Tue, Aug 22, 2017 at 02:55:39PM +0200, Rafael J. Wysocki wrote: > > On Tuesday, August 22, 2017 5:20:02 AM CEST Chen Yu wrote: [...] > > > void mark_free_pages(struct zone *zone) > > > { > > > - unsigned long pfn, max_zone_pfn; > > > + unsigned long p

Re: [PATCH][v2] PM / Hibernate: Feed the wathdog when creating snapshot

2017-08-22 Thread Chen Yu
On Tue, Aug 22, 2017 at 02:55:39PM +0200, Rafael J. Wysocki wrote: > On Tuesday, August 22, 2017 5:20:02 AM CEST Chen Yu wrote: > > There is a problem that when counting the pages for creating > > the hibernation snapshot will take significant amount of > > time, especially on system with large mem

Re: [PATCH][v2] PM / Hibernate: Feed the wathdog when creating snapshot

2017-08-22 Thread Rafael J. Wysocki
On Tuesday, August 22, 2017 3:16:50 PM CEST Michal Hocko wrote: > On Tue 22-08-17 14:55:39, Rafael J. Wysocki wrote: > [...] > > And you may want to touch the watchdog at the end too in case > > page_count is small then. > > Why would that be needed? If the number of pages is slow then we will > r

Re: [PATCH][v2] PM / Hibernate: Feed the wathdog when creating snapshot

2017-08-22 Thread Michal Hocko
On Tue 22-08-17 14:55:39, Rafael J. Wysocki wrote: [...] > And you may want to touch the watchdog at the end too in case > page_count is small then. Why would that be needed? If the number of pages is slow then we will release the IRQ lock early and won't need to care about watchdog at all. -- Mi

Re: [PATCH][v2] PM / Hibernate: Feed the wathdog when creating snapshot

2017-08-22 Thread Rafael J. Wysocki
On Tuesday, August 22, 2017 5:20:02 AM CEST Chen Yu wrote: > There is a problem that when counting the pages for creating > the hibernation snapshot will take significant amount of > time, especially on system with large memory. Since the counting > job is performed with irq disabled, this might le