Re: [PATCH][next] regulator: lp87565: fix missing break in switch statement

2019-07-02 Thread Mark Brown
On Tue, Jul 02, 2019 at 12:12:10PM +0100, Colin Ian King wrote: > On 02/07/2019 11:44, Lee Jones wrote: > > On Fri, 28 Jun 2019, Colin Ian King wrote: > >> So it applies cleanly against linux-next, I think the original code > >> landed in mfd/for-mfd-next - c.f. https://lkml.org/lkml/2019/5/28/550

Re: [PATCH][next] regulator: lp87565: fix missing break in switch statement

2019-07-02 Thread Lee Jones
On Tue, 02 Jul 2019, Colin Ian King wrote: > On 02/07/2019 11:44, Lee Jones wrote: > > On Fri, 28 Jun 2019, Colin Ian King wrote: > > > >> On 28/06/2019 15:36, Mark Brown wrote: > >>> On Thu, Jun 27, 2019 at 02:16:39PM +0100, Colin King wrote: > From: Colin Ian King > > Currently

Re: [PATCH][next] regulator: lp87565: fix missing break in switch statement

2019-07-02 Thread Keerthy
On 02/07/19 5:01 PM, Lee Jones wrote: On Tue, 02 Jul 2019, Colin Ian King wrote: On 02/07/2019 11:44, Lee Jones wrote: On Fri, 28 Jun 2019, Colin Ian King wrote: On 28/06/2019 15:36, Mark Brown wrote: On Thu, Jun 27, 2019 at 02:16:39PM +0100, Colin King wrote: From: Colin Ian King Cur

Re: [PATCH][next] regulator: lp87565: fix missing break in switch statement

2019-07-02 Thread Colin Ian King
On 02/07/2019 11:44, Lee Jones wrote: > On Fri, 28 Jun 2019, Colin Ian King wrote: > >> On 28/06/2019 15:36, Mark Brown wrote: >>> On Thu, Jun 27, 2019 at 02:16:39PM +0100, Colin King wrote: From: Colin Ian King Currently the LP87565_DEVICE_TYPE_LP87561_Q1 case does not have a

Re: [PATCH][next] regulator: lp87565: fix missing break in switch statement

2019-07-02 Thread Lee Jones
On Fri, 28 Jun 2019, Colin Ian King wrote: > On 28/06/2019 15:36, Mark Brown wrote: > > On Thu, Jun 27, 2019 at 02:16:39PM +0100, Colin King wrote: > >> From: Colin Ian King > >> > >> Currently the LP87565_DEVICE_TYPE_LP87561_Q1 case does not have a > >> break statement, causing it to fall throug

Re: [PATCH][next] regulator: lp87565: fix missing break in switch statement

2019-06-28 Thread Colin Ian King
On 28/06/2019 15:36, Mark Brown wrote: > On Thu, Jun 27, 2019 at 02:16:39PM +0100, Colin King wrote: >> From: Colin Ian King >> >> Currently the LP87565_DEVICE_TYPE_LP87561_Q1 case does not have a >> break statement, causing it to fall through to a dev_err message. >> Fix this by adding in the mis

Re: [PATCH][next] regulator: lp87565: fix missing break in switch statement

2019-06-28 Thread Mark Brown
On Thu, Jun 27, 2019 at 02:16:39PM +0100, Colin King wrote: > From: Colin Ian King > > Currently the LP87565_DEVICE_TYPE_LP87561_Q1 case does not have a > break statement, causing it to fall through to a dev_err message. > Fix this by adding in the missing break statement. This doesn't apply aga

Re: [PATCH][next] regulator: lp87565: fix missing break in switch statement

2019-06-27 Thread Keerthy
On 27/06/19 6:46 PM, Colin King wrote: From: Colin Ian King Currently the LP87565_DEVICE_TYPE_LP87561_Q1 case does not have a break statement, causing it to fall through to a dev_err message. Fix this by adding in the missing break statement. Addresses-Coverity: ("Missing break in switch")