Re: [PATCH] Usbatm: convert heavy init dances to kthread API

2008-02-11 Thread Duncan Sands
> Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> > Tested-by: Duncan Sands <[EMAIL PROTECTED]> Signed-off-by: Duncan Sands <[EMAIL PROTECTED]> Thanks again for doing this! Best wishes, Duncan. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messag

Re: [PATCH][USBATM]: convert heavy init dances to kthread API

2008-02-11 Thread Duncan Sands
On Monday 11 February 2008 12:22:27 Pavel Emelyanov wrote: > Duncan Sands wrote: > > Hi Pavel, > > > >> Oh, I see. You're right - this race is possible... I'll fix that up > >> if this patch works. > > > > it seems to work fine. Thanks again for doing this! > > Oh, thanks for testing. What shou

Re: [PATCH][USBATM]: convert heavy init dances to kthread API

2008-02-11 Thread Pavel Emelyanov
Duncan Sands wrote: > Hi Pavel, > >> Oh, I see. You're right - this race is possible... I'll fix that up >> if this patch works. > > it seems to work fine. Thanks again for doing this! Oh, thanks for testing. What should I do next to get this into mainline? Send it to Andrew with you in Cc, or

Re: [PATCH][USBATM]: convert heavy init dances to kthread API

2008-02-10 Thread Duncan Sands
Hi Pavel, > Oh, I see. You're right - this race is possible... I'll fix that up > if this patch works. it seems to work fine. Thanks again for doing this! Best wishes, Duncan. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTE

Re: [PATCH][USBATM]: convert heavy init dances to kthread API

2008-02-07 Thread Pavel Emelyanov
Alan Stern wrote: > On Thu, 7 Feb 2008, Pavel Emelyanov wrote: > >>> Does the kthread API guarantee that the kthread is not running until you >>> call >> It does. That's why the race, you mentioned above is impossible. > > That is wrong. The API guarantees only that the kthread is initially >

Re: [PATCH][USBATM]: convert heavy init dances to kthread API

2008-02-07 Thread Alan Stern
On Thu, 7 Feb 2008, Pavel Emelyanov wrote: > > Does the kthread API guarantee that the kthread is not running until you > > call > > It does. That's why the race, you mentioned above is impossible. That is wrong. The API guarantees only that the kthread is initially created in a non-running s

Re: [PATCH][USBATM]: convert heavy init dances to kthread API

2008-02-07 Thread Pavel Emelyanov
Duncan Sands wrote: > Hi Pavel, > @@ -1014,11 +1015,7 @@ static int usbatm_do_heavy_init(void *arg) struct usbatm_data *instance = arg; int ret; - daemonize(instance->driver->driver_name); allow_signal(SIGTERM); - instance->thread_pid = current->pid;

Re: [PATCH][USBATM]: convert heavy init dances to kthread API

2008-02-07 Thread Duncan Sands
Hi Pavel, > >> @@ -1014,11 +1015,7 @@ static int usbatm_do_heavy_init(void *arg) > >>struct usbatm_data *instance = arg; > >>int ret; > >> > >> - daemonize(instance->driver->driver_name); > >>allow_signal(SIGTERM); > >> - instance->thread_pid = current->pid; > >> - > >> - complete

Re: [PATCH][USBATM]: convert heavy init dances to kthread API

2008-02-07 Thread Pavel Emelyanov
Duncan Sands wrote: > Hi, > >> The problem is that I couldn't find the maintainer for the code >> in drivers/usb/atm/. > > that would be me (though since I haven't used this modem in years I would > be more than happy to hand it off to someone else). > >> Besides, I don't have a proper hardware

Re: [PATCH][USBATM]: convert heavy init dances to kthread API

2008-02-06 Thread Duncan Sands
Hi, > The problem is that I couldn't find the maintainer for the code > in drivers/usb/atm/. that would be me (though since I haven't used this modem in years I would be more than happy to hand it off to someone else). > Besides, I don't have a proper hardware to test this. I will try to find