Re: [PATCH][1/3] ppc32: add 440ep support

2005-07-28 Thread Domen Puncer
On 27/07/05 18:56 -0400, Paul Mackerras wrote: > Andrew Morton writes: > > > Matt Porter <[EMAIL PROTECTED]> wrote: > > > > > > +static u64 dma_mask = 0xULL; How about just DMA_32BIT_MASK from dma-mapping.h, that one has to be correct. ;-) > > > > I'm sure you're totally uninterested in

Re: [PATCH][1/3] ppc32: add 440ep support

2005-07-27 Thread Andrew Morton
Paul Mackerras <[EMAIL PROTECTED]> wrote: > > Andrew Morton writes: > > > Matt Porter <[EMAIL PROTECTED]> wrote: > > > > > > +static u64 dma_mask = 0xULL; > > > > I'm sure you're totally uninterested in this, but the above will probably > > generate warnings on (say) ppc64, where u64 is i

Re: [PATCH][1/3] ppc32: add 440ep support

2005-07-27 Thread Paul Mackerras
Andrew Morton writes: > Matt Porter <[EMAIL PROTECTED]> wrote: > > > > +static u64 dma_mask = 0xULL; > > I'm sure you're totally uninterested in this, but the above will probably > generate warnings on (say) ppc64, where u64 is implemented as unsigned > long. > > I usually chuck a simple

Re: [PATCH][1/3] ppc32: add 440ep support

2005-07-27 Thread Andrew Morton
Matt Porter <[EMAIL PROTECTED]> wrote: > > +static u64 dma_mask = 0xULL; I'm sure you're totally uninterested in this, but the above will probably generate warnings on (say) ppc64, where u64 is implemented as unsigned long. I usually chuck a simple `-1' in there and the compiler always ge