Re: [PATCH/RFC] workqueue: allow rescuer thread to do more work.

2014-11-14 Thread Tejun Heo
Hello, On Tue, Nov 11, 2014 at 09:04:02AM +1100, NeilBrown wrote: > diff --git a/kernel/workqueue.c b/kernel/workqueue.c > index 09b685daee3d..f2db6073c498 100644 > --- a/kernel/workqueue.c > +++ b/kernel/workqueue.c > @@ -2235,11 +2235,6 @@ repeat: > struct work_struct *work, *n; >

Re: [PATCH/RFC] workqueue: allow rescuer thread to do more work.

2014-11-10 Thread NeilBrown
On Mon, 10 Nov 2014 09:52:50 +0100 Jan Kara wrote: > On Mon 10-11-14 16:28:48, NeilBrown wrote: > > On Fri, 7 Nov 2014 11:03:40 +0800 Lai Jiangshan > > wrote: > > > On 11/07/2014 12:58 AM, Dongsu Park wrote: > > > > Hi Tejun & Neil, > > > > > > > > On 04.11.2014 09:22, Tejun Heo wrote: > > > >

Re: [PATCH/RFC] workqueue: allow rescuer thread to do more work.

2014-11-10 Thread Jan Kara
On Mon 10-11-14 16:28:48, NeilBrown wrote: > On Fri, 7 Nov 2014 11:03:40 +0800 Lai Jiangshan wrote: > > On 11/07/2014 12:58 AM, Dongsu Park wrote: > > > Hi Tejun & Neil, > > > > > > On 04.11.2014 09:22, Tejun Heo wrote: > > >> On Thu, Oct 30, 2014 at 10:19:32AM +1100, NeilBrown wrote: > >

Re: [PATCH/RFC] workqueue: allow rescuer thread to do more work.

2014-11-09 Thread NeilBrown
On Fri, 7 Nov 2014 11:03:40 +0800 Lai Jiangshan wrote: > > > On 11/07/2014 12:58 AM, Dongsu Park wrote: > > Hi Tejun & Neil, > > > > On 04.11.2014 09:22, Tejun Heo wrote: > >> On Thu, Oct 30, 2014 at 10:19:32AM +1100, NeilBrown wrote: > Given that workder depleti

Re: [PATCH/RFC] workqueue: allow rescuer thread to do more work.

2014-11-06 Thread Lai Jiangshan
On 11/07/2014 12:58 AM, Dongsu Park wrote: > Hi Tejun & Neil, > > On 04.11.2014 09:22, Tejun Heo wrote: >> On Thu, Oct 30, 2014 at 10:19:32AM +1100, NeilBrown wrote: Given that workder depletion is pool-wide event, maybe it'd make sense to trigger rescuers imm

Re: [PATCH/RFC] workqueue: allow rescuer thread to do more work.

2014-11-06 Thread Dongsu Park
Hi Tejun & Neil, On 04.11.2014 09:22, Tejun Heo wrote: > On Thu, Oct 30, 2014 at 10:19:32AM +1100, NeilBrown wrote: > > > Given that workder depletion is pool-wide > > > event, maybe it'd make sense to trigger rescuers immediately while > > > workers are in short supply?

Re: [PATCH/RFC] workqueue: allow rescuer thread to do more work.

2014-11-04 Thread Tejun Heo
Hello, Neil. Sorry about the delay. On Thu, Oct 30, 2014 at 10:19:32AM +1100, NeilBrown wrote: > > Given that workder depletion is pool-wide > > event, maybe it'd make sense to trigger rescuers immediately while > > workers are in short supply? e.g. while there's a mana

Re: [PATCH/RFC] workqueue: allow rescuer thread to do more work.

2014-10-29 Thread NeilBrown
On Wed, 29 Oct 2014 10:32:10 -0400 Tejun Heo wrote: > Hello, Neil. > > On Wed, Oct 29, 2014 at 05:26:08PM +1100, NeilBrown wrote: > > Hi Tejun, > > I haven't tested this patch yet so this really is an 'RFC'. > > In general ->nr_active should only be accessed under the pool->lock, > > but a mis

Re: [PATCH/RFC] workqueue: allow rescuer thread to do more work.

2014-10-29 Thread Tejun Heo
Hello, Neil. On Wed, Oct 29, 2014 at 05:26:08PM +1100, NeilBrown wrote: > Hi Tejun, > I haven't tested this patch yet so this really is an 'RFC'. > In general ->nr_active should only be accessed under the pool->lock, > but a miss-read here will at most cause a very occasional 100ms delay so > sh