Re: [PATCH/RFC] perf core: Allow setting up max frame stack depth via sysctl

2016-04-21 Thread Arnaldo Carvalho de Melo
Em Thu, Apr 21, 2016 at 12:17:07PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Apr 21, 2016 at 12:48:58PM +0200, Peter Zijlstra escreveu: > > On Wed, Apr 20, 2016 at 07:47:30PM -0300, Arnaldo Carvalho de Melo wrote: > > > +++ b/kernel/events/callchain.c > > > > @@ -73,7 +81,7 @@ static int

Re: [PATCH/RFC] perf core: Allow setting up max frame stack depth via sysctl

2016-04-21 Thread Arnaldo Carvalho de Melo
Em Thu, Apr 21, 2016 at 12:48:58PM +0200, Peter Zijlstra escreveu: > On Wed, Apr 20, 2016 at 07:47:30PM -0300, Arnaldo Carvalho de Melo wrote: > > The default remains 127, which is good for most cases, and not even hit > > most of the time, but then for some cases, as reported by Brendan, 1024+ > >

Re: [PATCH/RFC] perf core: Allow setting up max frame stack depth via sysctl

2016-04-21 Thread Peter Zijlstra
On Wed, Apr 20, 2016 at 07:47:30PM -0300, Arnaldo Carvalho de Melo wrote: > The default remains 127, which is good for most cases, and not even hit > most of the time, but then for some cases, as reported by Brendan, 1024+ > deep frames are appearing on the radar for things like groovy, ruby. yea

Re: [PATCH/RFC] perf core: Allow setting up max frame stack depth via sysctl

2016-04-20 Thread Arnaldo Carvalho de Melo
Em Wed, Apr 20, 2016 at 05:10:17PM -0600, David Ahern escreveu: > On 4/20/16 4:47 PM, Arnaldo Carvalho de Melo wrote: > > # echo 256 > /proc/sys/kernel/perf_event_max_stack > > # cat /proc/sys/kernel/perf_event_max_stack > > 256 > I would love to see something like this go in. Right now I h

Re: [PATCH/RFC] perf core: Allow setting up max frame stack depth via sysctl

2016-04-20 Thread David Ahern
On 4/20/16 4:47 PM, Arnaldo Carvalho de Melo wrote: The new file is: # cat /proc/sys/kernel/perf_event_max_stack 127 Chaging it: # echo 256 > /proc/sys/kernel/perf_event_max_stack # cat /proc/sys/kernel/perf_event_max_stack 256 But as soon as there is some event using callchain

Re: [PATCH/RFC] perf core: Allow setting up max frame stack depth via sysctl

2016-04-20 Thread Alexei Starovoitov
On Wed, Apr 20, 2016 at 07:47:30PM -0300, Arnaldo Carvalho de Melo wrote: > The default remains 127, which is good for most cases, and not even hit > most of the time, but then for some cases, as reported by Brendan, 1024+ > deep frames are appearing on the radar for things like groovy, ruby. >