Re: [PATCH/RFC] eradicate bashisms in scripts/patch-kernel

2007-11-17 Thread Sam Ravnborg
On Sat, Nov 17, 2007 at 05:33:27PM +0100, Andreas Mohr wrote: > Hi, > > On Wed, Nov 14, 2007 at 02:46:27PM -0800, Randy Dunlap wrote: > > On Mon, 5 Nov 2007 20:58:27 +0100 Andreas Mohr wrote: > > > Feel free to go ahead, otherwise I'll try another patch sometime soon. > > > All I care about is tha

Re: [PATCH/RFC] eradicate bashisms in scripts/patch-kernel

2007-11-17 Thread Adrian Bunk
On Wed, Oct 31, 2007 at 10:13:21PM +0100, Andreas Mohr wrote: > Hello, Hi Andreas, > I was non-mildly horrified to find that the rather widely used patch-kernel > script seems to rely on bash despite specifying the interpreter as #!/bin/sh, > since my dash-using Debian install choked on it. > >

Re: [PATCH/RFC] eradicate bashisms in scripts/patch-kernel

2007-11-17 Thread Herbert Xu
On Sat, Nov 17, 2007 at 05:33:27PM +0100, Andreas Mohr wrote: > > # strip EXTRAVERSION to just a number (drop leading '.' and trailing > additions) > EXTRAVER= > if [ x$EXTRAVERSION != "x" ] > then > >>> [l.207] if [ ${EXTRAVERSION:0:1} == "." ]; then > EXTRAVER=${EXTRAVERSIO

Re: [PATCH/RFC] eradicate bashisms in scripts/patch-kernel

2007-11-17 Thread Andreas Mohr
Hi, On Wed, Nov 14, 2007 at 02:46:27PM -0800, Randy Dunlap wrote: > On Mon, 5 Nov 2007 20:58:27 +0100 Andreas Mohr wrote: > > Feel free to go ahead, otherwise I'll try another patch sometime soon. > > All I care about is that the result works on (at least) > > one shell implementation _more_ than

Re: [PATCH/RFC] eradicate bashisms in scripts/patch-kernel

2007-11-14 Thread Randy Dunlap
On Mon, 5 Nov 2007 20:58:27 +0100 Andreas Mohr wrote: > > Would you resend a trimmed-down patch? > > or should I do it? > > Feel free to go ahead, otherwise I'll try another patch sometime soon. > All I care about is that the result works on (at least) > one shell implementation _more_ than the c

Re: [PATCH/RFC] eradicate bashisms in scripts/patch-kernel

2007-11-05 Thread Andreas Mohr
Hi, On Fri, Nov 02, 2007 at 01:17:07PM -0700, Randy Dunlap wrote: > On Fri, 2 Nov 2007 21:09:35 +0100 Andreas Mohr wrote: > > > Hi, > > > I'm now quite certain on which side to tweak things ;) > > The other parts of your patch should probably be merged IMO. Hmm, that particular part consists o

Re: [PATCH/RFC] eradicate bashisms in scripts/patch-kernel

2007-11-02 Thread Randy Dunlap
On Fri, 2 Nov 2007 21:09:35 +0100 Andreas Mohr wrote: > Hi, > I'm now quite certain on which side to tweak things ;) The other parts of your patch should probably be merged IMO. Would you resend a trimmed-down patch? or should I do it? Thanks, --- ~Randy - To unsubscribe from this list: send t

Re: [PATCH/RFC] eradicate bashisms in scripts/patch-kernel

2007-11-02 Thread Andreas Mohr
Hi, On Fri, Nov 02, 2007 at 10:01:18AM +0800, Herbert Xu wrote: > On Thu, Nov 01, 2007 at 04:08:57PM -0700, Randy Dunlap wrote: > > I think that this is the part that bothers me. I can't find > > anything at > > http://www.opengroup.org/onlinepubs/95399/utilities/xcu_chap02.html > > that says

Re: [PATCH/RFC] eradicate bashisms in scripts/patch-kernel

2007-11-01 Thread Herbert Xu
On Thu, Nov 01, 2007 at 04:08:57PM -0700, Randy Dunlap wrote: > > > - replace non-standard bash string parsing by sed expression > > (is the sed syntax ok? correct? strict enough?) > > I think that this is the part that bothers me. I can't find > anything at > http://www.opengroup.org/onlinepub

Re: [PATCH/RFC] eradicate bashisms in scripts/patch-kernel

2007-11-01 Thread Randy Dunlap
On Thu, 1 Nov 2007 23:16:06 +0100 Andreas Mohr wrote: [add Herbert] > Hi, > > On Thu, Nov 01, 2007 at 08:24:57AM -0700, Randy Dunlap wrote: > > On Thu, 1 Nov 2007 13:11:33 +0100 Andreas Mohr wrote: > > > I'll think a bit more about these couple changed places (and whether > > > this still truly

Re: [PATCH/RFC] eradicate bashisms in scripts/patch-kernel

2007-11-01 Thread Andreas Mohr
Hi, On Thu, Nov 01, 2007 at 08:24:57AM -0700, Randy Dunlap wrote: > On Thu, 1 Nov 2007 13:11:33 +0100 Andreas Mohr wrote: > > I'll think a bit more about these couple changed places (and whether > > this still truly works as intended) and mail a patch then. > > > > (and a big NOTE: I'm no POSIX v

Re: [PATCH/RFC] eradicate bashisms in scripts/patch-kernel

2007-11-01 Thread Randy Dunlap
On Thu, 1 Nov 2007 13:11:33 +0100 Andreas Mohr wrote: > On Wed, Oct 31, 2007 at 03:24:22PM -0700, Randy Dunlap wrote: > > Andreas Mohr wrote: > > >- the "source" statement most likely needs the ./ prepended, as can be > > >gathered from e.g. http://osdir.com/ml/colinux.devel/2005-12/msg00036.html

Re: [PATCH/RFC] eradicate bashisms in scripts/patch-kernel

2007-11-01 Thread Andreas Mohr
On Wed, Oct 31, 2007 at 03:24:22PM -0700, Randy Dunlap wrote: > Andreas Mohr wrote: > >- the "source" statement most likely needs the ./ prepended, as can be > >gathered from e.g. http://osdir.com/ml/colinux.devel/2005-12/msg00036.html > > That email isn't very convincing to me. Actually that pla

Re: [PATCH/RFC] eradicate bashisms in scripts/patch-kernel

2007-10-31 Thread Randy Dunlap
Andreas Mohr wrote: Hello, I was non-mildly horrified to find that the rather widely used patch-kernel script seems to rely on bash despite specifying the interpreter as #!/bin/sh, since my dash-using Debian install choked on it. Thus I'm delivering a first, preliminary, non-reviewed change to