Re: [GIT PULL] x86 fixes for 3.11-rc2

2013-07-21 Thread H. Peter Anvin
On 07/20/2013 05:25 AM, George Spelvin wrote: > It's marginal with only two call sites, but would it be worth factoring > out the write-back function? Something like this (untested) patch. > It definitely makes the generated assembly cleaner. > > (Signed-off-by: George Spelvin if you want it.)

Re: [GIT PULL] x86 fixes for 3.11-rc2

2013-07-20 Thread Borislav Petkov
On Sat, Jul 20, 2013 at 10:47:58AM -0400, George Spelvin wrote: > Borislav Petkov wrote: > > I don't think that matters because this is called only once on suspend. > > Unless the cleaner assembly translates into a palpable speedup, which I > > doubt. > > I was thinking about code *size*, actuall

Re: [GIT PULL] x86 fixes for 3.11-rc2

2013-07-20 Thread George Spelvin
Borislav Petkov wrote: > I don't think that matters because this is called only once on suspend. > Unless the cleaner assembly translates into a palpable speedup, which I > doubt. I was thinking about code *size*, actually; I agree that speed is too small to measure. Clean code (21 bytes): 4e:

Re: [GIT PULL] x86 fixes for 3.11-rc2

2013-07-20 Thread Borislav Petkov
On Sat, Jul 20, 2013 at 08:25:04AM -0400, George Spelvin wrote: > It's marginal with only two call sites, but would it be worth factoring > out the write-back function? Something like this (untested) patch. > It definitely makes the generated assembly cleaner. I don't think that matters because t

Re: [GIT PULL] x86 fixes for 3.11-rc2

2013-07-20 Thread George Spelvin
It's marginal with only two call sites, but would it be worth factoring out the write-back function? Something like this (untested) patch. It definitely makes the generated assembly cleaner. (Signed-off-by: George Spelvin if you want it.) diff --git a/arch/x86/include/asm/msr.h b/arch/x86/inclu

Re: [OT] Re: [GIT PULL] x86 fixes for 3.11-rc2

2013-07-19 Thread H. Peter Anvin
On 07/19/2013 02:38 AM, Geert Uytterhoeven wrote: > > Can we please stop writing these _mixed_ English/Finnish emails? > Nyet. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at h

Re: [OT] Re: [GIT PULL] x86 fixes for 3.11-rc2

2013-07-19 Thread Geert Uytterhoeven
On Fri, Jul 19, 2013 at 9:45 AM, Lukasz Sokol wrote: > H. Peter Anvin zytor.com> writes: >> Ehkä meidän sääntö, että kiroilu on sallittu vain suomeksi (ja venäjä, >> muuten Al Viro todennäköisesti räjähtää.) Can we please stop writing these _mixed_ English/Finnish emails? As Chrome only offers t

[OT] Re: [GIT PULL] x86 fixes for 3.11-rc2

2013-07-19 Thread Lukasz Sokol
H. Peter Anvin zytor.com> writes: > Ehkä meidän sääntö, että kiroilu on sallittu vain suomeksi (ja venäjä, > muuten Al Viro todennäköisesti räjähtää.) > > -hpa Try pasting that back into Google Translate ;) see what Viro is translated to ;) -L ;) --- These lines are added to increase m

Re: [GIT PULL] x86 fixes for 3.11-rc2

2013-07-18 Thread H. Peter Anvin
On 07/18/2013 05:46 PM, Linus Torvalds wrote: > > Finnish is hard. But good for swearing. > Ehkä meidän sääntö, että kiroilu on sallittu vain suomeksi (ja venäjä, muuten Al Viro todennäköisesti räjähtää.) -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: [GIT PULL] x86 fixes for 3.11-rc2

2013-07-18 Thread H. Peter Anvin
On 07/18/2013 05:46 PM, Linus Torvalds wrote: > > Finnish is hard. But good for swearing. > http://www.youtube.com/watch?v=b1fkMuMDqXI It probably won't make too much sense if you haven't seen: http://www.youtube.com/watch?v=_4bka9Y2gJ0 -hpa -- To unsubscribe from this list: send the

Re: [GIT PULL] x86 fixes for 3.11-rc2

2013-07-18 Thread Myklebust, Trond
On Thu, 2013-07-18 at 17:46 -0700, Linus Torvalds wrote: > Finnish is hard. But good for swearing. Only because the ratio of vowels to consonants causes an immediate outbreak of swearing among those who try... Trond -- Trond Myklebust Linux NFS client maintainer NetApp trond.mykleb...@netapp.c

Re: [GIT PULL] x86 fixes for 3.11-rc2

2013-07-18 Thread Linus Torvalds
Google translate is getting better. I was going to ask you who you knew who had enough of a Finnish background to do that, but decided to see what I could make google translate do. I'm pretty sure google didn't _use_ to do that good a job at Finnish. It would be "pääksi", not "pää", but I think yo