On Thu, 2008-01-03 at 18:11 -0500, Rik van Riel wrote:
> On Thu, 03 Jan 2008 15:20:09 -0500
> David Dillow <[EMAIL PROTECTED]> wrote:
>
> > diff --git a/drivers/infiniband/ulp/srp/ib_srp.c
> > b/drivers/infiniband/ulp/srp/ib_srp.c
> > index 950228f..6e7e3c8 100644
> > --- a/drivers/infiniband/ulp
On Thu, 03 Jan 2008 15:20:09 -0500
David Dillow <[EMAIL PROTECTED]> wrote:
> diff --git a/drivers/infiniband/ulp/srp/ib_srp.c
> b/drivers/infiniband/ulp/srp/ib_srp.c
> index 950228f..6e7e3c8 100644
> --- a/drivers/infiniband/ulp/srp/ib_srp.c
> +++ b/drivers/infiniband/ulp/srp/ib_srp.c
> @@ -423,8
> @@ -423,8 +423,8 @@ static void srp_remove_work(struct work_struct *work)
> list_del(&target->list);
> spin_unlock(&target->srp_host->target_lock);
>
> -srp_remove_host(target->scsi_host);
> scsi_remove_host(target->scsi_host);
> +srp_remove_host(target->scsi_host)
Subject: IB/srp: Fix list corruption/oops on module reload
ib_srp doesn't clean up the transport attributes properly when
unloading, so it leaves references around to free'd memory.
The srp_remove_host() cannot go before the scsi_remove_host() call as
the documented call sequence suggests, as it
On Thu, 2008-01-03 at 10:56 -0800, Roland Dreier wrote:
> > If we've got time before 2.6.24 final, I'd wait on this a bit.
> > ib_srp:srp_remove_work() has them reversed as well, and I'm currently
> > tracking down why it oopses when the srp_remove_host() happens before
> > the scsi_remove_host
> If we've got time before 2.6.24 final, I'd wait on this a bit.
> ib_srp:srp_remove_work() has them reversed as well, and I'm currently
> tracking down why it oopses when the srp_remove_host() happens before
> the scsi_remove_host(), which is the documented call sequence.
I think the best thi
On Thu, 2008-01-03 at 10:29 -0800, Roland Dreier wrote:
> Linus, please pull from
>
> master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git
> for-linus
>
> This tree is also available from kernel.org mirrors at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/roland/infin
On Thu, 11 Oct 2007 18:17:19 -0700 (PDT)
David Miller <[EMAIL PROTECTED]> wrote:
> From: Roland Dreier <[EMAIL PROTECTED]>
> Date: Thu, 11 Oct 2007 18:08:52 -0700
>
> > This will get the batch of changes queued up for the 2.6.24 merge
> > window (although I still have a few more things to merge l
> > I'm not sure what you mean. During the 2.6.23 cycle I've been sending
> > any patches that potentially could conflict with the net-2.6 tree to
> > you and Jeff so that you can merge them upstream via your tree. Or do
> > you mean Jeff should become the maintainer of drivers/infiniband??
Linus Torvalds wrote:
Oh, and obviously, the NAPI changes may well have resulted in a merge that
had no actual *conflicts* in it, but whether the end result works or not
(and whether any IB drivers need updating due to the NAPI changes), I
cannot tell. I've pushed out my tree, so people who are
On Thu, 11 Oct 2007, Greg KH wrote:
> On Thu, Oct 11, 2007 at 07:58:04PM -0700, Linus Torvalds wrote:
> >
> > So I merged it all, and I don't expect any problems, but I'm hoping
> > somebody is thinking about that mod_devicetable.h/file2alias.c mess.
> >
> > I'm not entirely sure who to blame
On Thu, Oct 11, 2007 at 07:58:04PM -0700, Linus Torvalds wrote:
>
> So I merged it all, and I don't expect any problems, but I'm hoping
> somebody is thinking about that mod_devicetable.h/file2alias.c mess.
>
> I'm not entirely sure who to blame on that thing. I'm adding Greg to the
> Cc, on th
From: Linus Torvalds <[EMAIL PROTECTED]>
Date: Thu, 11 Oct 2007 19:58:04 -0700 (PDT)
>
>
> On Thu, 11 Oct 2007, David Miller wrote:
> >
> > Even if you're confident there won't be merge issues, could you just
> > wait for the net-2.6 stuff to go in first?
>
> I pulled the net stuff first, and
On Thu, 11 Oct 2007, David Miller wrote:
>
> Even if you're confident there won't be merge issues, could you just
> wait for the net-2.6 stuff to go in first?
I pulled the net stuff first, and merged the IB stuff afterwards. No
conflicts in IB, but there *were* conflicts with the networking pu
From: Roland Dreier <[EMAIL PROTECTED]>
Date: Thu, 11 Oct 2007 19:21:06 -0700
> I'm not sure what you mean. During the 2.6.23 cycle I've been sending
> any patches that potentially could conflict with the net-2.6 tree to
> you and Jeff so that you can merge them upstream via your tree. Or do
> y
> > This will get the batch of changes queued up for the 2.6.24 merge
> > window (although I still have a few more things to merge later, once
> > Dave Miller's networking tree has landed too):
>
> Roland are you absolutely sure this won't create merge conflicts with
> my 8MB net-2.6 merge,
From: Roland Dreier <[EMAIL PROTECTED]>
Date: Thu, 11 Oct 2007 18:08:52 -0700
> This will get the batch of changes queued up for the 2.6.24 merge
> window (although I still have a few more things to merge later, once
> Dave Miller's networking tree has landed too):
Roland are you absolutely sure
Hi Roland,
On Thursday 16 August 2007 18:19, Roland Dreier wrote:
> > Hmm, if these things are appropriate for 2.6.23, maybe my patch
> > adding linux/mutex.h to ehca_classes.h can go in too?
>
> Actually I queued Dotan's patches quite a while ago, although Linus
> seems to be ignoring my pull
> Hmm, if these things are appropriate for 2.6.23, maybe my patch
> adding linux/mutex.h to ehca_classes.h can go in too?
Actually I queued Dotan's patches quite a while ago, although Linus
seems to be ignoring my pull requests.
I don't see any urgency in adding more similar patches to 2.6.23,
> Dotan Barak (3):
> IB: Include from
> IB: Include and from
Hmm, if these things are appropriate for 2.6.23, maybe my patch
adding linux/mutex.h to ehca_classes.h can go in too?
--
MST
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a me
20 matches
Mail list logo