Re: [Cbe-oss-dev] [RFC] Cell: shutdown method for spu_sysdev_class

2007-05-30 Thread Arnd Bergmann
On Wednesday 30 May 2007, Christoph Hellwig wrote: > > > Is it documented or implied somewhere that ->shutdown must not free > > the device? If not, the first option is probably the safer choice. > > It's not documented anywhere, but implicitly assumed.  I don't know > of any shutdown implementat

Re: [Cbe-oss-dev] [RFC] Cell: shutdown method for spu_sysdev_class

2007-05-30 Thread Christoph Hellwig
On Tue, May 29, 2007 at 08:23:49PM +0200, Arnd Bergmann wrote: > On Sunday 06 May 2007, Geoff Levand wrote: > > --- ps3-linux-dev.orig/arch/powerpc/platforms/cell/spu_base.c > > +++ ps3-linux-dev/arch/powerpc/platforms/cell/spu_base.c > > @@ -463,8 +463,21 @@ void spu_free(struct spu *spu) > > } >

Re: [Cbe-oss-dev] [RFC] Cell: shutdown method for spu_sysdev_class

2007-05-29 Thread Arnd Bergmann
On Sunday 06 May 2007, Geoff Levand wrote: > --- ps3-linux-dev.orig/arch/powerpc/platforms/cell/spu_base.c > +++ ps3-linux-dev/arch/powerpc/platforms/cell/spu_base.c > @@ -463,8 +463,21 @@ void spu_free(struct spu *spu) > } > EXPORT_SYMBOL_GPL(spu_free); > > +static int spu_shutdown(struct sys_de