Re: [CHECKER] 84 bugs in 2.4.4/2.4.4-ac8 where NULL pointers are deref'd

2001-05-29 Thread Andreas Dilger
Al Viro writes: > On Tue, 29 May 2001, Andreas Dilger wrote: > > For ext2 it is pretty much the same, except ext2_delete_entry() called > > ext2_check_dir_entry() with a NULL input (for some reason), but it could > > easily supply a valid input value. All callers to ext2_delete_entry() > > derefe

Re: [CHECKER] 84 bugs in 2.4.4/2.4.4-ac8 where NULL pointers are deref'd

2001-05-29 Thread Dawson Engler
> And if you look a couple lines previous it is blindly dereferenced, > this should have been a clue :-) There's a lot of places where code checks and then blindly dereferences, so I don't think that's much of a clue ;-) > > Start ---> > >struct rtable *rt = skb ? (struct rtable*)skb->dst

Re: [CHECKER] 84 bugs in 2.4.4/2.4.4-ac8 where NULL pointers are deref'd

2001-05-29 Thread David S. Miller
[ Steve: Just skim down to the decnet bug, you should have a look at it. Philip: Similarly, skim down to the econet bug. ] Dawson Engler writes: > [BUG] sends sk raw to a bunch of other routines. doesn't seem good. > /u2/engler/mc/oses/linux/2.4.4-ac8/net/ipv4/ip_output.c:520:ip_