Re: [CFT PATCH v2 0/2] KVM: support XSAVES usage in the host

2014-12-01 Thread Wanpeng Li
Hi Paolo, On Tue, Nov 25, 2014 at 04:50:06PM +0200, Nadav Amit wrote: [...] >I am just worried that Wanpeng reported it fails, while I report it works... I just get a real skylake-client machine on hand, both the two patches from you can run normally, it seems that the silly emulator which I used

Re: [CFT PATCH v2 0/2] KVM: support XSAVES usage in the host

2014-11-26 Thread Paolo Bonzini
On 26/11/2014 02:24, Wanpeng Li wrote: > Hi all, > On Tue, Nov 25, 2014 at 04:50:06PM +0200, Nadav Amit wrote: >> >>> On Nov 25, 2014, at 16:17, Paolo Bonzini wrote: >>> >>> >>> >>> On 25/11/2014 15:05, Nadav Amit wrote: > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 373b

Re: [CFT PATCH v2 0/2] KVM: support XSAVES usage in the host

2014-11-26 Thread Wanpeng Li
Hi Nadav, On Wed, Nov 26, 2014 at 11:00:34AM +0200, Nadav Amit wrote: >Wanpeng Li wrote: > >> Hi all, >> On Tue, Nov 25, 2014 at 04:50:06PM +0200, Nadav Amit wrote: On Nov 25, 2014, at 16:17, Paolo Bonzini wrote: On 25/11/2014 15:05, Nadav Amit wrote: >> diff --git

Re: [CFT PATCH v2 0/2] KVM: support XSAVES usage in the host

2014-11-26 Thread Nadav Amit
Wanpeng Li wrote: > Hi all, > On Tue, Nov 25, 2014 at 04:50:06PM +0200, Nadav Amit wrote: >>> On Nov 25, 2014, at 16:17, Paolo Bonzini wrote: >>> >>> >>> >>> On 25/11/2014 15:05, Nadav Amit wrote: > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 373b0ab9a32e..ca26681455c

Re: [CFT PATCH v2 0/2] KVM: support XSAVES usage in the host

2014-11-25 Thread Wanpeng Li
Hi all, On Tue, Nov 25, 2014 at 04:50:06PM +0200, Nadav Amit wrote: > >> On Nov 25, 2014, at 16:17, Paolo Bonzini wrote: >> >> >> >> On 25/11/2014 15:05, Nadav Amit wrote: diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 373b0ab9a32e..ca26681455c2 100644 --- a/arch/x86/

Re: [CFT PATCH v2 0/2] KVM: support XSAVES usage in the host

2014-11-25 Thread Nadav Amit
> On Nov 25, 2014, at 16:17, Paolo Bonzini wrote: > > > > On 25/11/2014 15:05, Nadav Amit wrote: >>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c >>> index 373b0ab9a32e..ca26681455c2 100644 >>> --- a/arch/x86/kvm/x86.c >>> +++ b/arch/x86/kvm/x86.c >>> @@ -6955,6 +6955,9 @@ int fx_init(

Re: [CFT PATCH v2 0/2] KVM: support XSAVES usage in the host

2014-11-25 Thread Paolo Bonzini
On 25/11/2014 15:05, Nadav Amit wrote: > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > > index 373b0ab9a32e..ca26681455c2 100644 > > --- a/arch/x86/kvm/x86.c > > +++ b/arch/x86/kvm/x86.c > > @@ -6955,6 +6955,9 @@ int fx_init(struct kvm_vcpu *vcpu) > > return err; > > > >

Re: [CFT PATCH v2 0/2] KVM: support XSAVES usage in the host

2014-11-25 Thread Nadav Amit
> On Nov 25, 2014, at 12:36, Paolo Bonzini wrote: > > > > On 25/11/2014 11:13, Wanpeng Li wrote: >> Hi Paolo, >> On Mon, Nov 24, 2014 at 05:43:32PM +0100, Paolo Bonzini wrote: >>> The first patch ensures that XSAVES is not exposed in the guest until >>> we emulate MSR_IA32_XSS. The second exp

Re: [CFT PATCH v2 0/2] KVM: support XSAVES usage in the host

2014-11-25 Thread Paolo Bonzini
On 25/11/2014 11:13, Wanpeng Li wrote: > Hi Paolo, > On Mon, Nov 24, 2014 at 05:43:32PM +0100, Paolo Bonzini wrote: >> The first patch ensures that XSAVES is not exposed in the guest until >> we emulate MSR_IA32_XSS. The second exports XSAVE data in the correct >> format. >> >> I tested these on

Re: [CFT PATCH v2 0/2] KVM: support XSAVES usage in the host

2014-11-25 Thread Wanpeng Li
Hi Paolo, On Mon, Nov 24, 2014 at 05:43:32PM +0100, Paolo Bonzini wrote: >The first patch ensures that XSAVES is not exposed in the guest until >we emulate MSR_IA32_XSS. The second exports XSAVE data in the correct >format. > >I tested these on a non-XSAVES system so they should not be completely