Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

2015-11-25 Thread Rafael J. Wysocki
On 11/25/2015 9:12 AM, Jiang Liu wrote: On 2015/11/25 6:19, Rafael J. Wysocki wrote: On Tue, Nov 24, 2015 at 5:49 PM, Bjorn Helgaas wrote: On Mon, Nov 16, 2015 at 12:27:37PM +0800, Jiang Liu wrote: From: Liu Jiang Commit 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support PCI host

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

2015-11-25 Thread Arthur Marsh
Jiang Liu wrote on 25/11/15 18:57: Hi Arthur, Thanks for reminder again! It's a little strange, the formal patch "[Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245" is based on the debug patch I sent to you at 9 November 2015. Could you please help to try the attac

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

2015-11-25 Thread Jiang Liu
On 2015/11/25 8:32, Arthur Marsh wrote: > Keith Busch wrote on 25/11/15 09:34: >> On Tue, Nov 24, 2015 at 11:19:34PM +0100, Rafael J. Wysocki wrote: >>> Quite frankly, I'm more likely to revert the offending commit at this >>> point as that's not the only regression reported against it and the >>>

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

2015-11-25 Thread Jiang Liu
On 2015/11/25 6:19, Rafael J. Wysocki wrote: > On Tue, Nov 24, 2015 at 5:49 PM, Bjorn Helgaas wrote: >> On Mon, Nov 16, 2015 at 12:27:37PM +0800, Jiang Liu wrote: >>> From: Liu Jiang >>> >>> Commit 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support >>> PCI host bridge") converted x86 to

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

2015-11-24 Thread Arthur Marsh
Keith Busch wrote on 25/11/15 09:34: On Tue, Nov 24, 2015 at 11:19:34PM +0100, Rafael J. Wysocki wrote: Quite frankly, I'm more likely to revert the offending commit at this point as that's not the only regression reported against it and the fix only helps in one case (out of three known to me).

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

2015-11-24 Thread Keith Busch
On Tue, Nov 24, 2015 at 11:19:34PM +0100, Rafael J. Wysocki wrote: > Quite frankly, I'm more likely to revert the offending commit at this > point as that's not the only regression reported against it and the > fix only helps in one case (out of three known to me). Using 4.4-rc1 and can confirm th

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

2015-11-24 Thread Rafael J. Wysocki
On Tue, Nov 24, 2015 at 5:49 PM, Bjorn Helgaas wrote: > On Mon, Nov 16, 2015 at 12:27:37PM +0800, Jiang Liu wrote: >> From: Liu Jiang >> >> Commit 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support >> PCI host bridge") converted x86 to use the common interface >> acpi_pci_root_create, b

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

2015-11-24 Thread Bjorn Helgaas
On Mon, Nov 16, 2015 at 12:27:37PM +0800, Jiang Liu wrote: > From: Liu Jiang > > Commit 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support > PCI host bridge") converted x86 to use the common interface > acpi_pci_root_create, but the conversion missed on code piece in > arch/x86/pci/bus_

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

2015-11-16 Thread Hans de Bruin
On 11/16/2015 08:06 AM, Arthur Marsh wrote: Jiang Liu wrote on 16/11/15 14:57: From: Liu Jiang Commit 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support PCI host bridge") converted x86 to use the common interface acpi_pci_root_create, but the conversion missed on code piece in arch

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

2015-11-15 Thread Arthur Marsh
Jiang Liu wrote on 16/11/15 14:57: From: Liu Jiang Commit 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support PCI host bridge") converted x86 to use the common interface acpi_pci_root_create, but the conversion missed on code piece in arch/x86/pci/bus_numa.c, which causes regression