Re: [BUGFIX PATCH] kprobes/x86: Remove IRQ disabling from jprobe handlers

2017-10-05 Thread Masami Hiramatsu
On Thu, 5 Oct 2017 09:57:04 +0200 Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > On Wed, 4 Oct 2017 12:41:01 +0200 > > Ingo Molnar wrote: > > > > > > > > * Masami Hiramatsu wrote: > > > > > > > Hmm, actually we can not disable jprobe, that has no separate Kconfig. > > > > So we ne

Re: [BUGFIX PATCH] kprobes/x86: Remove IRQ disabling from jprobe handlers

2017-10-05 Thread Ingo Molnar
* Masami Hiramatsu wrote: > On Wed, 4 Oct 2017 12:41:01 +0200 > Ingo Molnar wrote: > > > > > * Masami Hiramatsu wrote: > > > > > Hmm, actually we can not disable jprobe, that has no separate Kconfig. > > > So we need to introduce new kconfig for that. > > > > > > And, there are several net

Re: [BUGFIX PATCH] kprobes/x86: Remove IRQ disabling from jprobe handlers

2017-10-04 Thread Masami Hiramatsu
On Wed, 4 Oct 2017 12:41:01 +0200 Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > Hmm, actually we can not disable jprobe, that has no separate Kconfig. > > So we need to introduce new kconfig for that. > > > > And, there are several network protocols using jprobe to trace events. > >

Re: [BUGFIX PATCH] kprobes/x86: Remove IRQ disabling from jprobe handlers

2017-10-04 Thread Ingo Molnar
* Masami Hiramatsu wrote: > Hmm, actually we can not disable jprobe, that has no separate Kconfig. > So we need to introduce new kconfig for that. > > And, there are several network protocols using jprobe to trace events. > (e.g. NET_DCCPPROBE and NET_TCPPROBE) > I think they need to migrate to

Re: [BUGFIX PATCH] kprobes/x86: Remove IRQ disabling from jprobe handlers

2017-10-03 Thread Masami Hiramatsu
On Tue, 3 Oct 2017 19:11:00 +0200 Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > On Tue, 3 Oct 2017 11:33:44 +0200 > > Ingo Molnar wrote: > > > > > > > > * Masami Hiramatsu wrote: > > > > > > > Jprobe actually doesn't need to disable IRQs while calling > > > > handlers, because Do

Re: [BUGFIX PATCH] kprobes/x86: Remove IRQ disabling from jprobe handlers

2017-10-03 Thread Ingo Molnar
* Masami Hiramatsu wrote: > On Tue, 3 Oct 2017 11:33:44 +0200 > Ingo Molnar wrote: > > > > > * Masami Hiramatsu wrote: > > > > > Jprobe actually doesn't need to disable IRQs while calling > > > handlers, because Documentation/kprobes.txt says: > > > > > > - > > > Probe handlers are ru

Re: [BUGFIX PATCH] kprobes/x86: Remove IRQ disabling from jprobe handlers

2017-10-03 Thread Masami Hiramatsu
On Tue, 3 Oct 2017 11:33:44 +0200 Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > Jprobe actually doesn't need to disable IRQs while calling > > handlers, because Documentation/kprobes.txt says: > > > > - > > Probe handlers are run with preemption disabled. Depending on the > >

Re: [BUGFIX PATCH] kprobes/x86: Remove IRQ disabling from jprobe handlers

2017-10-03 Thread Ingo Molnar
* Masami Hiramatsu wrote: > Jprobe actually doesn't need to disable IRQs while calling > handlers, because Documentation/kprobes.txt says: > > - > Probe handlers are run with preemption disabled. Depending on the > architecture and optimization state, handlers may also run with > interr