Re: [BUG] Race between policy reload sidtab conversion and live conversion

2021-03-01 Thread Paul Moore
On Mon, Mar 1, 2021 at 5:36 AM Ondrej Mosnacek wrote: > On Sun, Feb 28, 2021 at 8:21 PM Paul Moore wrote: > > On Fri, Feb 26, 2021 at 6:12 AM Ondrej Mosnacek wrote: > > > On Fri, Feb 26, 2021 at 2:07 AM Paul Moore wrote: > > > > On Wed, Feb 24, 2021 at 4:35 AM Ondrej Mosnacek > > > > wrote:

Re: [BUG] Race between policy reload sidtab conversion and live conversion

2021-03-01 Thread Ondrej Mosnacek
On Sat, Feb 27, 2021 at 3:35 AM Hillf Danton wrote: > On Fri, 26 Feb 2021 12:19:35 +0100 Ondrej Mosnacek wrote: > > On Fri, Feb 26, 2021 at 5:08 AM Hillf Danton wrote: > > > On Thu, 25 Feb 2021 20:06:45 -0500 Paul Moore wrote: > > > > On Wed, Feb 24, 2021 at 4:35 AM Ondrej Mosnacek > > > > wro

Re: [BUG] Race between policy reload sidtab conversion and live conversion

2021-03-01 Thread Ondrej Mosnacek
On Sun, Feb 28, 2021 at 8:21 PM Paul Moore wrote: > On Fri, Feb 26, 2021 at 6:12 AM Ondrej Mosnacek wrote: > > On Fri, Feb 26, 2021 at 2:07 AM Paul Moore wrote: > > > On Wed, Feb 24, 2021 at 4:35 AM Ondrej Mosnacek > > > wrote: > > > > After the switch to RCU, we now have: > > > > 1. Start liv

Re: [BUG] Race between policy reload sidtab conversion and live conversion

2021-02-28 Thread Paul Moore
On Fri, Feb 26, 2021 at 6:12 AM Ondrej Mosnacek wrote: > On Fri, Feb 26, 2021 at 2:07 AM Paul Moore wrote: > > On Wed, Feb 24, 2021 at 4:35 AM Ondrej Mosnacek wrote: > > > After the switch to RCU, we now have: > > > 1. Start live conversion of new entries. > > > 2. Convert existing entries. > >

Re: [BUG] Race between policy reload sidtab conversion and live conversion

2021-02-26 Thread Ondrej Mosnacek
On Fri, Feb 26, 2021 at 5:08 AM Hillf Danton wrote: > On Thu, 25 Feb 2021 20:06:45 -0500 Paul Moore wrote: > > On Wed, Feb 24, 2021 at 4:35 AM Ondrej Mosnacek wrote: > > > After the switch to RCU, we now have: > > > 1. Start live conversion of new entries. > > > 2. Convert existing entries. > > >

Re: [BUG] Race between policy reload sidtab conversion and live conversion

2021-02-26 Thread Ondrej Mosnacek
On Fri, Feb 26, 2021 at 2:07 AM Paul Moore wrote: > On Wed, Feb 24, 2021 at 4:35 AM Ondrej Mosnacek wrote: > > After the switch to RCU, we now have: > > 1. Start live conversion of new entries. > > 2. Convert existing entries. > > 3. RCU-assign the new policy pointer to selinux_state. > > [!!! No

Re: [BUG] Race between policy reload sidtab conversion and live conversion

2021-02-25 Thread Paul Moore
On Wed, Feb 24, 2021 at 4:35 AM Ondrej Mosnacek wrote: > After the switch to RCU, we now have: > 1. Start live conversion of new entries. > 2. Convert existing entries. > 3. RCU-assign the new policy pointer to selinux_state. > [!!! Now actually both old and new sidtab may be referenced by > reade

Re: [BUG] Race between policy reload sidtab conversion and live conversion

2021-02-25 Thread Paul Moore
On Thu, Feb 25, 2021 at 11:38 AM Ondrej Mosnacek wrote: > Unless someone objects, I'll start working on a patch to switch back > to read-write lock for now. If all goes well, I'll send it sometime > next week. Sorry, I was looking at other things and just got to this ... I'm not overly excited ab

Re: [BUG] Race between policy reload sidtab conversion and live conversion

2021-02-25 Thread Tyler Hicks
On 2021-02-25 17:38:25, Ondrej Mosnacek wrote: > On Wed, Feb 24, 2021 at 3:43 PM Tyler Hicks > wrote: > > On 2021-02-24 10:33:46, Ondrej Mosnacek wrote: > > > On Tue, Feb 23, 2021 at 11:37 PM Tyler Hicks > > > wrote: > > > > On 2021-02-23 15:50:56, Tyler Hicks wrote: > > > > > On 2021-02-23 15:4

Re: [BUG] Race between policy reload sidtab conversion and live conversion

2021-02-25 Thread Ondrej Mosnacek
On Wed, Feb 24, 2021 at 3:43 PM Tyler Hicks wrote: > On 2021-02-24 10:33:46, Ondrej Mosnacek wrote: > > On Tue, Feb 23, 2021 at 11:37 PM Tyler Hicks > > wrote: > > > On 2021-02-23 15:50:56, Tyler Hicks wrote: > > > > On 2021-02-23 15:43:48, Tyler Hicks wrote: > > > > > I'm seeing a race during po

Re: [BUG] Race between policy reload sidtab conversion and live conversion

2021-02-24 Thread Tyler Hicks
On 2021-02-24 10:33:46, Ondrej Mosnacek wrote: > On Tue, Feb 23, 2021 at 11:37 PM Tyler Hicks > wrote: > > On 2021-02-23 15:50:56, Tyler Hicks wrote: > > > On 2021-02-23 15:43:48, Tyler Hicks wrote: > > > > I'm seeing a race during policy load while the "regular" sidtab > > > > conversion is happe

Re: [BUG] Race between policy reload sidtab conversion and live conversion

2021-02-24 Thread Ondrej Mosnacek
On Tue, Feb 23, 2021 at 11:37 PM Tyler Hicks wrote: > On 2021-02-23 15:50:56, Tyler Hicks wrote: > > On 2021-02-23 15:43:48, Tyler Hicks wrote: > > > I'm seeing a race during policy load while the "regular" sidtab > > > conversion is happening and a live conversion starts to take place in > > > si

Re: [BUG] Race between policy reload sidtab conversion and live conversion

2021-02-23 Thread Paul Moore
On Tue, Feb 23, 2021 at 5:36 PM Tyler Hicks wrote: > On 2021-02-23 15:50:56, Tyler Hicks wrote: > > On 2021-02-23 15:43:48, Tyler Hicks wrote: > > > I'm seeing a race during policy load while the "regular" sidtab > > > conversion is happening and a live conversion starts to take place in > > > sid

Re: [BUG] Race between policy reload sidtab conversion and live conversion

2021-02-23 Thread Tyler Hicks
On 2021-02-23 15:50:56, Tyler Hicks wrote: > On 2021-02-23 15:43:48, Tyler Hicks wrote: > > I'm seeing a race during policy load while the "regular" sidtab > > conversion is happening and a live conversion starts to take place in > > sidtab_context_to_sid(). > > > > We have an initial policy that'

Re: [BUG] Race between policy reload sidtab conversion and live conversion

2021-02-23 Thread Tyler Hicks
On 2021-02-23 15:43:48, Tyler Hicks wrote: > I'm seeing a race during policy load while the "regular" sidtab > conversion is happening and a live conversion starts to take place in > sidtab_context_to_sid(). > > We have an initial policy that's loaded by systemd ~0.6s into boot and > then another