Re: [AppArmor 19/45] Add struct vfsmount parameters to vfs_rename()

2007-11-02 Thread Peter Zijlstra
On Fri, 2007-11-02 at 11:14 +0100, Bodo Eggert wrote: > /me prepares for the impact of a large round object on earth. /me ponders the implications of the impact of a 2 dimensional object colliding with a 3 dimensional object in real life. - To unsubscribe from this list: send the line "unsubscri

Re: [AppArmor 19/45] Add struct vfsmount parameters to vfs_rename()

2007-11-02 Thread Bodo Eggert
Al Viro <[EMAIL PROTECTED]> wrote: > On Fri, Oct 26, 2007 at 11:23:53AM -0700, John Johansen wrote: >> In the current code, both vfsmounts are always identical, and so one of >> the two should go, agreed. >> >> The thought behind passing both vfsmounts was that they could differ but >> point to t

Re: [AppArmor 19/45] Add struct vfsmount parameters to vfs_rename()

2007-10-26 Thread Al Viro
On Fri, Oct 26, 2007 at 11:23:53AM -0700, John Johansen wrote: > In the current code, both vfsmounts are always identical, and so one of > the two should go, agreed. > > The thought behind passing both vfsmounts was that they could differ but > point to the same super_block, in which case renames

Re: [AppArmor 19/45] Add struct vfsmount parameters to vfs_rename()

2007-10-26 Thread John Johansen
On Fri, Oct 26, 2007 at 08:37:49AM +0100, Al Viro wrote: > On Thu, Oct 25, 2007 at 11:40:43PM -0700, [EMAIL PROTECTED] wrote: > > The vfsmount will be passed down to the LSM hook so that LSMs can compute > > pathnames. > > You know, you really are supposed to understand the code you are modifying.

Re: [AppArmor 19/45] Add struct vfsmount parameters to vfs_rename()

2007-10-26 Thread Al Viro
On Thu, Oct 25, 2007 at 11:40:43PM -0700, [EMAIL PROTECTED] wrote: > The vfsmount will be passed down to the LSM hook so that LSMs can compute > pathnames. You know, you really are supposed to understand the code you are modifying... Quiz: what are those vfsmounts and how are they related? Al, ca