Re: [ALSA] seq: resource leak fix and various code cleanups

2007-08-07 Thread Eugene Teo
> At Tue, 7 Aug 2007 18:52:49 +0800, > Eugene Teo wrote: [...] > I fixed these and applied your patch to ALSA tree now. > Thanks! Thanks! Will take note next time. Eugene - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: [ALSA] seq: resource leak fix and various code cleanups

2007-08-07 Thread Takashi Iwai
At Tue, 7 Aug 2007 18:52:49 +0800, Eugene Teo wrote: > > diff --git a/sound/core/seq/oss/seq_oss_init.c > b/sound/core/seq/oss/seq_oss_init.c > index ca5a2ed..f26b751 100644 > --- a/sound/core/seq/oss/seq_oss_init.c > +++ b/sound/core/seq/oss/seq_oss_init.c > @@ -176,29 +176,31 @@ snd_seq_oss_ope

Re: [ALSA] seq: resource leak fix and various code cleanups

2007-08-07 Thread Eugene Teo
Hi Takashi-san, > At Tue, 7 Aug 2007 16:40:48 +0800, > Eugene Teo wrote: > > > > This patch fixes: > > 1) a resource leak (CID: 1817) > > 2) various code cleanups [...] > > if (i >= SNDRV_SEQ_OSS_MAX_CLIENTS) { > > snd_printk(KERN_ERR "too many applications\n"); > > - k

Re: [ALSA] seq: resource leak fix and various code cleanups

2007-08-07 Thread Takashi Iwai
At Tue, 7 Aug 2007 16:40:48 +0800, Eugene Teo wrote: > > This patch fixes: > 1) a resource leak (CID: 1817) > 2) various code cleanups > > Signed-off-by: Eugene Teo <[EMAIL PROTECTED]> > --- > sound/core/seq/oss/seq_oss_init.c | 29 ++--- > sound/core/seq/oss/seq_oss_