Re: [2.6 patch] unexport complete_all

2005-03-08 Thread Bartlomiej Zolnierkiewicz
On Fri, 4 Mar 2005 14:14:39 +0100, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > On Fri, 4 Mar 2005 03:15:04 -0800, Andrew Morton <[EMAIL PROTECTED]> wrote: > > Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > > > > > > Andrew, what is the policy for adding exports for out of tree GP

Re: [2.6 patch] unexport complete_all

2005-03-04 Thread Adrian Bunk
On Fri, Mar 04, 2005 at 12:08:33PM -0500, [EMAIL PROTECTED] wrote: > > Did you just blindly grep the userspace tarball? > > There is no kernel code in there. It's all in linux-2.6.*-autofsng-*.patch. Sorry, my bad. I couldn't connect to your FTP server this morning (I don't know why) and I fo

Re: [2.6 patch] unexport complete_all

2005-03-04 Thread mike
> On Fri, Mar 04, 2005 at 11:40:08AM +0100, Bartlomiej Zolnierkiewicz wrote: >> On Fri, 04 Mar 2005 03:09:39 -0500, Mike Waychison <[EMAIL PROTECTED]> >> wrote: >> > > I didn't find any possible modular usage in the kernel. >> > > >> > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> >> > > >> > >

Re: [2.6 patch] unexport complete_all

2005-03-04 Thread mike
> On Fri, Mar 04, 2005 at 03:09:39AM -0500, Mike Waychison wrote: >> > I didn't find any possible modular usage in the kernel. >> > >> > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> >> > >> > --- linux-2.6.11-rc5-mm1-full/kernel/sched.c.old 2005-03-04 >> 01:04:28.0 +0100 >> > +++ linux-

Re: [2.6 patch] unexport complete_all

2005-03-04 Thread Bartlomiej Zolnierkiewicz
On Fri, 4 Mar 2005 03:15:04 -0800, Andrew Morton <[EMAIL PROTECTED]> wrote: > Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > > > > Andrew, what is the policy for adding exports for out of tree GPL code? > > > > There isn't one. Such things cause way too much email. Lack of policy causes

Re: [2.6 patch] unexport complete_all

2005-03-04 Thread Adrian Bunk
On Fri, Mar 04, 2005 at 03:15:04AM -0800, Andrew Morton wrote: >... > So it's a sensible part of the completion API from a regularity-of-the-API > POV. We use it in the coredump code and I don't think we'd be likely to want > to rip it out. >... Modular coredump code? cu Adrian -- "Is

Re: [2.6 patch] unexport complete_all

2005-03-04 Thread Alan Cox
> Andrew, what is the policy for adding exports for out of tree GPL code? > > IMHO although it is convenient for maintainers of such code it is > inconvenient for us (ie. when making changes to code) and gives > people false assumptions about stability of *in-kernel* APIs. Why isn't it _GPL if it

Re: [2.6 patch] unexport complete_all

2005-03-04 Thread Andrew Morton
Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > > Andrew, what is the policy for adding exports for out of tree GPL code? > There isn't one. Such things cause way too much email. What complete_all() does is to permit more than one task to wait on a completion and for all those tasks to b

Re: [2.6 patch] unexport complete_all

2005-03-04 Thread Adrian Bunk
On Fri, Mar 04, 2005 at 11:40:08AM +0100, Bartlomiej Zolnierkiewicz wrote: > On Fri, 04 Mar 2005 03:09:39 -0500, Mike Waychison <[EMAIL PROTECTED]> wrote: > > > I didn't find any possible modular usage in the kernel. > > > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > > > > > --- linux-2

Re: [2.6 patch] unexport complete_all

2005-03-04 Thread Adrian Bunk
On Fri, Mar 04, 2005 at 03:09:39AM -0500, Mike Waychison wrote: > > I didn't find any possible modular usage in the kernel. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > > > --- linux-2.6.11-rc5-mm1-full/kernel/sched.c.old2005-03-04 > > 01:04:28.0 +0100 > > +++ linux-2.6

Re: [2.6 patch] unexport complete_all

2005-03-04 Thread Bartlomiej Zolnierkiewicz
On Fri, 04 Mar 2005 03:09:39 -0500, Mike Waychison <[EMAIL PROTECTED]> wrote: > > I didn't find any possible modular usage in the kernel. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > > > --- linux-2.6.11-rc5-mm1-full/kernel/sched.c.old 2005-03-04 > > 01:04:28.0 +0100 > >

Re: [2.6 patch] unexport complete_all

2005-03-04 Thread Mike Waychison
> I didn't find any possible modular usage in the kernel. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- linux-2.6.11-rc5-mm1-full/kernel/sched.c.old 2005-03-04 > 01:04:28.0 +0100 > +++ linux-2.6.11-rc5-mm1-full/kernel/sched.c 2005-03-04 01:04:34.0 > +0100 > @@