Re: [2.6 patch] mm/swap_state.c: unexport swapper_space

2005-03-08 Thread Hugh Dickins
On Tue, 8 Mar 2005, Russell King wrote: > On Sun, Mar 06, 2005 at 10:49:12PM +, Christoph Hellwig wrote: > > I disagree. swapper_state is far too much of an internal detail to be > > exported. I argued that way when page_mapping was changed to use it and > > that's why the architectures moved

Re: [2.6 patch] mm/swap_state.c: unexport swapper_space

2005-03-08 Thread Russell King
On Sun, Mar 06, 2005 at 10:49:12PM +, Christoph Hellwig wrote: > I disagree. swapper_state is far too much of an internal detail to be > exported. I argued that way when page_mapping was changed to use it and > that's why the architectures moved their helpers out of line. > Looks like the exp

Re: [2.6 patch] mm/swap_state.c: unexport swapper_space

2005-03-06 Thread Christoph Hellwig
On Sun, Mar 06, 2005 at 03:28:19PM +, Hugh Dickins wrote: > immediately on demand). It's used by the inline page_mapping() in > include/linux/mm.h, which _was_ used by various arch cacheflushing > inlines, which could reasonably be called from modular filesystems. > > I think those architectu

Re: [2.6 patch] mm/swap_state.c: unexport swapper_space

2005-03-06 Thread Hugh Dickins
On Sun, 6 Mar 2005, Adrian Bunk wrote: > I didn't find any possible modular usage in the kernel. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- linux-2.6.11-mm1-full/mm/swap_state.c.old 2005-03-04 16:25:54.0 > +0100 > +++ linux-2.6.11-mm1-full/mm/swap_state.c 2005-03-04