Re: [2.6 patch] i2c-core.c: make some code static

On Mon, Jan 31, 2005 at 07:59:55PM +0100, Adrian Bunk wrote: > This patch makes some needlessly global code static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Applied, thanks. greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [

Re: [2.6 patch] i2c-core.c: make some code static

Hi Adrian, > > > -struct bus_type i2c_bus_type = { > > > - .name = "i2c", > > > - .match =i2c_device_match, > > > - .suspend = i2c_bus_suspend, > > > - .resume = i2c_bus_resume, > > > -}; > > (...) > > > > Is moving that code around really necessary? Looks to me like on

Re: [2.6 patch] i2c-core.c: make some code static

On Mon, Jan 31, 2005 at 09:50:50PM +0100, Jean Delvare wrote: > Hi Adrian, Hi Jean, >... > > -/* match always succeeds, as we want the probe() to tell if we really > > accept this match */ -static int i2c_device_match(struct device *dev, > > struct device_driver *drv) -{ > > - return 1; > > -}

Re: [2.6 patch] i2c-core.c: make some code static

Hi Adrian, > This patch makes some needlessly global code static. > (...) > @@ -38,12 +38,43 @@ > static DECLARE_MUTEX(core_lists); > static DEFINE_IDR(i2c_adapter_idr); > > -int i2c_device_probe(struct device *dev) > +/* match always succeeds, as we want the probe() to tell if we really > acc