Re: [2.6 patch] add compiler-gcc4.h

2005-02-05 Thread H. Peter Anvin
Adrian Bunk wrote: It doesn't seem to be logical for everyone whether compiler-gcc+.h or compiler-gcc3.h is used for gcc 4.0 ... Perhaps compiler-gcc+.h (which wasn't always updated when compiler-gcc3.h was updated) should be removed? That would make more sense. After all, gcc5+ can use the gc

Re: [2.6 patch] add compiler-gcc4.h

2005-02-05 Thread Adrian Bunk
On Sat, Feb 05, 2005 at 10:45:52AM -0800, H. Peter Anvin wrote: > Adrian Bunk wrote: > > > >As I already said in this thread: > > The currently used file for gcc 4 is compiler-gcc+.h, not > > compiler-gcc3.h . > > > >And the current setup is to have one file for every major number of gcc. > >I ha

Re: [2.6 patch] add compiler-gcc4.h

2005-02-05 Thread H. Peter Anvin
Adrian Bunk wrote: As I already said in this thread: The currently used file for gcc 4 is compiler-gcc+.h, not compiler-gcc3.h . And the current setup is to have one file for every major number of gcc. I have no strong opinion whether this approach or the approach of one file for all gcc versi

Re: [2.6 patch] add compiler-gcc4.h

2005-02-05 Thread Adrian Bunk
On Thu, Feb 03, 2005 at 01:04:46AM +, H. Peter Anvin wrote: > Followup to: <[EMAIL PROTECTED]> > By author:Matthias-Christian Ott <[EMAIL PROTECTED]> > In newsgroup: linux.dev.kernel > > > > Hi! > > But maybe gcc 4 will get different later, so I think this patch makes sense. > > > > No,

Re: [2.6 patch] add compiler-gcc4.h

2005-02-02 Thread H. Peter Anvin
Followup to: <[EMAIL PROTECTED]> By author:Matthias-Christian Ott <[EMAIL PROTECTED]> In newsgroup: linux.dev.kernel > > Hi! > But maybe gcc 4 will get different later, so I think this patch makes sense. > No, it doesn't. You fork when you have a reason. Eager forking is *BAD*. -

Re: [2.6 patch] add compiler-gcc4.h

2005-01-30 Thread Matthias-Christian Ott
Andi Kleen wrote: Adrian Bunk <[EMAIL PROTECTED]> writes: With the release of gcc 4.0 being only a few months away and people already tring compiling with it, it's time for adding a compiler-gcc4.h . This patch contains the following changes: - compiler-gcc+.h: add the missing noinline and __c

Re: [2.6 patch] add compiler-gcc4.h

2005-01-30 Thread Adrian Bunk
On Sun, Jan 30, 2005 at 03:11:19PM +0100, Andi Kleen wrote: > Adrian Bunk <[EMAIL PROTECTED]> writes: > > > With the release of gcc 4.0 being only a few months away and people > > already tring compiling with it, it's time for adding a compiler-gcc4.h . > > > > This patch contains the following c

Re: [2.6 patch] add compiler-gcc4.h

2005-01-30 Thread Andi Kleen
Adrian Bunk <[EMAIL PROTECTED]> writes: > With the release of gcc 4.0 being only a few months away and people > already tring compiling with it, it's time for adding a compiler-gcc4.h . > > This patch contains the following changes: > - compiler-gcc+.h: add the missing noinline and __compiler_off