Re: [2/3] mm: fix up some user-visible effects of the stack guard page

2015-01-06 Thread Jay Foad
On 5 January 2015 at 21:03, Linus Torvalds wrote: > On Mon, Jan 5, 2015 at 2:21 AM, Jay Foad wrote: >> Sorry for replying to this old email... >> >>> commit d7824370e26325c881b665350ce64fb0a4fde24a upstream > > Heh. From august 2010. That's 4+ years ago.. How come it was noticed > only now? *Not

Re: [2/3] mm: fix up some user-visible effects of the stack guard page

2015-01-05 Thread Linus Torvalds
On Mon, Jan 5, 2015 at 1:03 PM, Linus Torvalds wrote: > > IOW, *maybe* a patch like this. TOTALLY UNTESTED! I may have missed > something, and this may be complete crap. It does indeed seem to work. But see my other email about this effectively making the stack limit one page smaller. I'm not en

Re: [2/3] mm: fix up some user-visible effects of the stack guard page

2015-01-05 Thread Linus Torvalds
On Mon, Jan 5, 2015 at 1:03 PM, Linus Torvalds wrote: > > Yup, your analysis sounds correct. My completely untested gut feel is > that the problem is that we don't actually return the error from the > expand_stack() call, so then do_anonymous_page() will allow the extra > guard-page access. > > I

Re: [2/3] mm: fix up some user-visible effects of the stack guard page

2015-01-05 Thread Linus Torvalds
On Mon, Jan 5, 2015 at 2:21 AM, Jay Foad wrote: > Sorry for replying to this old email... > >> commit d7824370e26325c881b665350ce64fb0a4fde24a upstream Heh. From august 2010. That's 4+ years ago.. How come it was noticed only now? You guys are running excessively old kernels, methinks. > Address

Re: [2/3] mm: fix up some user-visible effects of the stack guard page

2015-01-05 Thread Jay Foad
Sorry for replying to this old email... On Wed, 2010-08-18 at 13:30 -0700, Greg KH wrote: > 2.6.35-stable review patch. If anyone has any objections, please let us know. > > -- > > From: Linus Torvalds > > commit d7824370e26325c881b665350ce64fb0a4fde24a upstream. > > This commit m