Re: [ patch 2/5] drivers/serial/jsm: new serial device driver

2005-03-30 Thread Kilau, Scott
> Wouldn't you think the kernel already takers are of flow control, given > that it already handles the sending of the X* characters? Hi Russell, Yes. The code was written by me before it was integrated into "serial core". Like your comments suggest, a lot of the "tty" code is now duplicated

Re: [ patch 2/5] drivers/serial/jsm: new serial device driver

2005-03-30 Thread Russell King
Here's some belated comments. I won't even pretend to understand any of your (imo overcomplex) driver - which is the reason I haven't bothered commenting before now. However, it seems that there may be some duplication between what you're doing and what the rest of the kernel is doing for you. Th

Re: [ patch 2/5] drivers/serial/jsm: new serial device driver

2005-03-11 Thread Wen Xiong
The second patch for new jsm serial device driver. Signed-off-by: Wen Xiong <[EMAIL PROTECTED]> diff -Nuar linux-2.6.11.org/drivers/serial/jsm/jsm_tty.c linux-2.6.11.new/drivers/serial/jsm/jsm_tty.c --- linux-2.6.11.org/drivers/serial/jsm/jsm_tty.c 1969-12-31 18:00:00.0 -0600 +++ li