Re: [ PATCH ]: disable pcspeaker kernel: 2.4.2 - 2.4.5

2001-05-31 Thread Nico Schottelius
Daniel Phillips wrote: > On Wednesday 30 May 2001 17:25, Ingo Molnar wrote: > > On Wed, 30 May 2001, Nico Schottelius wrote: > > > > the default value is 0, that is good enough. > > > > > > hmm.. I don't think so... value of 1 would be much better, because > > > 0 normally disables the speaker. >

Re: [ PATCH ]: disable pcspeaker kernel: 2.4.2 - 2.4.5

2001-05-30 Thread Daniel Phillips
On Wednesday 30 May 2001 17:25, Ingo Molnar wrote: > On Wed, 30 May 2001, Nico Schottelius wrote: > > > the default value is 0, that is good enough. > > > > hmm.. I don't think so... value of 1 would be much better, because > > 0 normally disables the speaker. > > i confused the value. Yes, an ini

Re: [ PATCH ]: disable pcspeaker kernel: 2.4.2 - 2.4.5

2001-05-30 Thread Ingo Molnar
On Wed, 30 May 2001, Nico Schottelius wrote: > > the default value is 0, that is good enough. > > hmm.. I don't think so... value of 1 would be much better, because > 0 normally disables the speaker. i confused the value. Yes, an initialization to 1 would be the correct, ie.: +++ linux-2.4.5-n

Re: [ PATCH ]: disable pcspeaker kernel: 2.4.2 - 2.4.5

2001-05-30 Thread Nico Schottelius
> > less code / one int more in the kernel > > or > > more code and #ifs / one int less in the kernel > > if the #ifdefs bloat the code 4 times the size of the simple patch, then > we obviously want 4 bytes more in the kernel. Okay. > > And what about the code from kernel/sys.c ? The version you

Re: [ PATCH ]: disable pcspeaker kernel: 2.4.2 - 2.4.5

2001-05-30 Thread Ingo Molnar
> less code / one int more in the kernel > or > more code and #ifs / one int less in the kernel if the #ifdefs bloat the code 4 times the size of the simple patch, then we obviously want 4 bytes more in the kernel. > And what about the code from kernel/sys.c ? The version you provided > doesn't

Re: [ PATCH ]: disable pcspeaker kernel: 2.4.2 - 2.4.5

2001-05-30 Thread Masoud Sharbiani
Hi! > And what about the code from kernel/sys.c ? > The version you provided doesn't take care of what's > the default value of pcspeaker. This would make it > undefined, which is not really good. Since the variable is global in kernel/sysctl.c (and not kernel/sys.c), and globals are set to z

Re: [ PATCH ]: disable pcspeaker kernel: 2.4.2 - 2.4.5

2001-05-30 Thread Nico Schottelius
Hi! Where did you put the config.in entries to ? This way it would be enabled all the time... okay... I like that, too. In the version I set up, I used the config.in entries, because if you use disable pc_speaker, there is at least one more int in the kernel. This is surely now much, but as it i

Re: [ PATCH ]: disable pcspeaker kernel: 2.4.2 - 2.4.5

2001-05-30 Thread Ingo Molnar
By making this (logical, and needed) feature unconditional, your patch's size and complexity is reduced by 80%. (see the attached pc_speaker.patch2) Ingo diff -u --recursive linux-2.4.5/drivers/char/vt.c linux-2.4.5-nc/drivers/char/vt.c --- linux-2.4.5/drivers/char/vt.c Fri Feb