Re: [ 020/184] ptrace: ensure arch_ptrace/ptrace_request can never

2013-06-07 Thread Luis Henriques
Oleg Nesterov writes: > On 06/05, Oleg Nesterov wrote: >> >> On 06/05, Luis Henriques wrote: >> > >> > /* Ensure that nothing can wake it up, even SIGKILL */ >> > -static bool ptrace_freeze_traced(struct task_struct *task) >> > +static bool ptrace_freeze_traced(struct task_struct *task, int kill

Re: [ 020/184] ptrace: ensure arch_ptrace/ptrace_request can never

2013-06-07 Thread Oleg Nesterov
On 06/05, Oleg Nesterov wrote: > > On 06/05, Luis Henriques wrote: > > > > /* Ensure that nothing can wake it up, even SIGKILL */ > > -static bool ptrace_freeze_traced(struct task_struct *task) > > +static bool ptrace_freeze_traced(struct task_struct *task, int kill) > > { > > - bool ret = fals

Re: [ 020/184] ptrace: ensure arch_ptrace/ptrace_request can never

2013-06-05 Thread Willy Tarreau
Hi Oleg, On Wed, Jun 05, 2013 at 05:49:51PM +0200, Oleg Nesterov wrote: > On 06/05, Oleg Nesterov wrote: > > > > Note: I can make a _much_ simpler patch for 2.6.32, please let me know > > if you need it. > > > > We can rely on sys_ptrace()->lock_kernel() and simply do lock/unlock > > if fatal_sign

Re: [ 020/184] ptrace: ensure arch_ptrace/ptrace_request can never

2013-06-05 Thread Oleg Nesterov
On 06/05, Oleg Nesterov wrote: > > Note: I can make a _much_ simpler patch for 2.6.32, please let me know > if you need it. > > We can rely on sys_ptrace()->lock_kernel() and simply do lock/unlock > if fatal_signal_pending() in ptrace_stop/do_signal_stop. This is not > the same, this doesn't preven

Re: [ 020/184] ptrace: ensure arch_ptrace/ptrace_request can never

2013-06-05 Thread Oleg Nesterov
On 06/05, Luis Henriques wrote: > > Willy Tarreau writes: > > > 2.6.32-longterm review patch. If anyone has any objections, please let me > > know. > > > > -- > > race with SIGKILL > > > > From: Oleg Nesterov > > > > ptrace: ensure arch_ptrace/ptrace_request can never race with

Re: [ 020/184] ptrace: ensure arch_ptrace/ptrace_request can never

2013-06-05 Thread Willy Tarreau
On Wed, Jun 05, 2013 at 10:36:06AM +0100, Luis Henriques wrote: > Willy Tarreau writes: > > > 2.6.32-longterm review patch. If anyone has any objections, please let me > > know. > > > > -- > > race with SIGKILL > > > > From: Oleg Nesterov > > > > ptrace: ensure arch_ptrace/ptr

Re: [ 020/184] ptrace: ensure arch_ptrace/ptrace_request can never

2013-06-05 Thread Luis Henriques
Willy Tarreau writes: > 2.6.32-longterm review patch. If anyone has any objections, please let me > know. > > -- > race with SIGKILL > > From: Oleg Nesterov > > ptrace: ensure arch_ptrace/ptrace_request can never race with SIGKILL > This patch actually introduce a regression