Re: [-mm patch] mm/memcontrol.c: clenups

2007-09-10 Thread Balbir Singh
Adrian Bunk wrote: > On Mon, Sep 10, 2007 at 01:53:19PM +0530, Balbir Singh wrote: >> Adrian Bunk wrote: >>> On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote: ... Changes since 2.6.23-rc3-mm1: ... +memory-controller-add-switch-to-control-what-type-of-pages-to-limit-

Re: [-mm patch] mm/memcontrol.c: clenups

2007-09-10 Thread Adrian Bunk
On Mon, Sep 10, 2007 at 01:53:19PM +0530, Balbir Singh wrote: > Adrian Bunk wrote: > > On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote: > >> ... > >> Changes since 2.6.23-rc3-mm1: > >> ... > >> +memory-controller-add-switch-to-control-what-type-of-pages-to-limit-v7.patch > >> ... > >>

Re: [-mm patch] mm/memcontrol.c: clenups

2007-09-10 Thread Jan Engelhardt
On Sep 10 2007 21:58, Jan Engelhardt wrote: >On Sep 10 2007 13:53, Balbir Singh wrote: >>> --- a/mm/memcontrol.c >>> +++ b/mm/memcontrol.c >>> @@ -91,7 +91,7 @@ enum { >>> MEM_CONTAINER_TYPE_CACHED, >>> MEM_CONTAINER_TYPE_ALL, >>> MEM_CONTAINER_TYPE_MAX, >>> -} mem_control_type; >>> +}

Re: [-mm patch] mm/memcontrol.c: clenups

2007-09-10 Thread Jan Engelhardt
On Sep 10 2007 13:53, Balbir Singh wrote: >> --- a/mm/memcontrol.c >> +++ b/mm/memcontrol.c >> @@ -91,7 +91,7 @@ enum { >> MEM_CONTAINER_TYPE_CACHED, >> MEM_CONTAINER_TYPE_ALL, >> MEM_CONTAINER_TYPE_MAX, >> -} mem_control_type; >> +}; >> > >Not sure about this, is this the preferre

Re: [-mm patch] mm/memcontrol.c: clenups

2007-09-10 Thread Balbir Singh
Adrian Bunk wrote: > On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote: >> ... >> Changes since 2.6.23-rc3-mm1: >> ... >> +memory-controller-add-switch-to-control-what-type-of-pages-to-limit-v7.patch >> ... >> memory containment >> ... > > This patch makes the following needlessly glo