Re: [-mm patch] drivers/pci/quirks.c: cleanup

Hi Mark, On Tue, 9 Jan 2007 22:58:20 -0500, Mark M. Hoffman wrote: > * Jean Delvare <[EMAIL PROTECTED]> [2007-01-09 14:17:21 +0100]: > > I am worried about the Intel/Asus SMBus quirk then, which affects many > > more users than the SiS SMBus one, and would suffer from a reordering as > > well. >

Re: [-mm patch] drivers/pci/quirks.c: cleanup

Hi Jean: > On Mon, 8 Jan 2007 22:02:26 -0500, Mark M. Hoffman wrote: > > 3) I've just confirmed that this quirk is still broken on recent FC6 > > kernels. > > Perhaps they should have picked my patch out of their bugzilla, but they > > didn't. * Jean Delvare <[EMAIL PROTECTED]> [2007-01-09 14:1

Re: [-mm patch] drivers/pci/quirks.c: cleanup

Hi Mark, On Mon, 8 Jan 2007 22:02:26 -0500, Mark M. Hoffman wrote: > Jean: > > * Jean Delvare <[EMAIL PROTECTED]> [2007-01-08 12:10:55 +0100]: > > Hi Mark, > > > > On Sun, 7 Jan 2007 10:44:41 -0500, Mark M. Hoffman wrote: > > > It is fragile for this code to depend on link order; Adrian's obviou

Re: [-mm patch] drivers/pci/quirks.c: cleanup

Jean: * Jean Delvare <[EMAIL PROTECTED]> [2007-01-08 12:10:55 +0100]: > Hi Mark, > > On Sun, 7 Jan 2007 10:44:41 -0500, Mark M. Hoffman wrote: > > Hi Jean, Adrian: > > > > > On Tue, 19 Dec 2006 05:13:15 +0100, Adrian Bunk wrote: > > > > @@ -1122,6 +1123,14 @@ static void quirk_sis_96x_smbus(stru

Re: [-mm patch] drivers/pci/quirks.c: cleanup

Hi Mark, On Sun, 7 Jan 2007 10:44:41 -0500, Mark M. Hoffman wrote: > Hi Jean, Adrian: > > > On Tue, 19 Dec 2006 05:13:15 +0100, Adrian Bunk wrote: > > > @@ -1122,6 +1123,14 @@ static void quirk_sis_96x_smbus(struct p > > > pci_write_config_byte(dev, 0x77, val & ~0x10); > > > pci_read_config_b

Re: [-mm patch] drivers/pci/quirks.c: cleanup

Hi Jean, Adrian, et. al.: * Jean Delvare <[EMAIL PROTECTED]> [2007-01-07 12:30:13 +0100]: > Hi Adrian, > > On Sat, 6 Jan 2007 00:29:13 +0100, Adrian Bunk wrote: > > While looking at the code, I also noted the following: > > > > quirk_sis_96x_compatible() is pretty useless since all it does is to

Re: [-mm patch] drivers/pci/quirks.c: cleanup

Hi Jean, Adrian: > On Tue, 19 Dec 2006 05:13:15 +0100, Adrian Bunk wrote: > > @@ -1122,6 +1123,14 @@ static void quirk_sis_96x_smbus(struct p > > pci_write_config_byte(dev, 0x77, val & ~0x10); > > pci_read_config_byte(dev, 0x77, &val); > > } > > +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SI,

Re: [-mm patch] drivers/pci/quirks.c: cleanup

Hi Adrian, On Sat, 6 Jan 2007 00:29:13 +0100, Adrian Bunk wrote: > While looking at the code, I also noted the following: > > quirk_sis_96x_compatible() is pretty useless since all it does is to set > a static variable that is only used in a printk(). > > quirk_sis_96x_compatible() was added wi

Re: [-mm patch] drivers/pci/quirks.c: cleanup

On Fri, Jan 05, 2007 at 09:52:33AM +0100, Jean Delvare wrote: > Hi Adrian, > > On Tue, 19 Dec 2006 05:13:15 +0100, Adrian Bunk wrote: > > This patch contains the following cleanups: > > - move all EXPORT_SYMBOL's directly below the code they are exporting > > - move all DECLARE_PCI_FIXUP_*'s direc

Re: [-mm patch] drivers/pci/quirks.c: cleanup

Hi Adrian, On Tue, 19 Dec 2006 05:13:15 +0100, Adrian Bunk wrote: > This patch contains the following cleanups: > - move all EXPORT_SYMBOL's directly below the code they are exporting > - move all DECLARE_PCI_FIXUP_*'s directly below the functions they > are calling Thanks for doing this cleanu

Re: [-mm patch] drivers/pci/quirks.c: cleanup

On Tue, Dec 19, 2006 at 01:52:49AM -0700, Matthew Wilcox wrote: > On Tue, Dec 19, 2006 at 05:13:15AM +0100, Adrian Bunk wrote: > > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SI, PCI_DEVICE_ID_SI_5597, > > quirk_nopcipci ); > > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SI, PCI_DEVICE_ID_SI_496,

Re: [-mm patch] drivers/pci/quirks.c: cleanup

On Tue, Dec 19, 2006 at 05:13:15AM +0100, Adrian Bunk wrote: > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SI,PCI_DEVICE_ID_SI_5597, > quirk_nopcipci ); > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SI,PCI_DEVICE_ID_SI_496, > quirk_nopcipci ); Why all the crazy spacing? +DECLAR