Re: + aio-completion-signal-notification.patch added to -mm tree

2007-01-26 Thread Sébastien Dugué
On Fri, 26 Jan 2007 14:52:33 +0300 Oleg Nesterov <[EMAIL PROTECTED]> wrote: > On 01/26, S?bastien Dugu? wrote: > > > > On Thu, 25 Jan 2007 19:21:41 +0300 Oleg Nesterov <[EMAIL PROTECTED]> wrote: > > > > > > + target = good_sigevent(&event); > > > > + > > > > + if (unlikely(!target ||

Re: + aio-completion-signal-notification.patch added to -mm tree

2007-01-26 Thread Oleg Nesterov
On 01/26, S?bastien Dugu? wrote: > > On Thu, 25 Jan 2007 19:21:41 +0300 Oleg Nesterov <[EMAIL PROTECTED]> wrote: > > > > + target = good_sigevent(&event); > > > + > > > + if (unlikely(!target || (target->flags & PF_EXITING))) > > > + goto out_unlock; > > > > PF_EXITING check is racy and u

Re: + aio-completion-signal-notification.patch added to -mm tree

2007-01-26 Thread Sébastien Dugué
On Thu, 25 Jan 2007 19:21:41 +0300 Oleg Nesterov <[EMAIL PROTECTED]> wrote: > Sebastien Dugue wrote: > > > > +static long aio_setup_sigevent(struct aio_notify *notify, > > + struct sigevent __user *user_event) > > +{ > > + sigevent_t event; > > + struct task_struct *ta

Re: + aio-completion-signal-notification.patch added to -mm tree

2007-01-25 Thread Oleg Nesterov
On 01/25, Oleg Nesterov wrote: > > Sebastien Dugue wrote: > > > > + if (iocb->ki_notify.notify != SIGEV_NONE) { > > + ret = aio_send_signal(&iocb->ki_notify); > > + > > + /* If signal generation failed, release the sigqueue */ > > + if (ret) > > + s

Re: + aio-completion-signal-notification.patch added to -mm tree

2007-01-25 Thread Oleg Nesterov
Sebastien Dugue wrote: > > +static long aio_setup_sigevent(struct aio_notify *notify, > +struct sigevent __user *user_event) > +{ > + sigevent_t event; > + struct task_struct *target; > + > + if (copy_from_user(&event, user_event, sizeof(event))) > +