Re: "mm: fix lazyfree BUG_ON check in try_to_unmap_one()" build error

2017-03-10 Thread Vlastimil Babka
On 03/10/2017 01:45 AM, Minchan Kim wrote: > Hi Andrew, > > On Thu, Mar 09, 2017 at 01:27:06PM -0800, Andrew Morton wrote: >> On Thu, 9 Mar 2017 15:02:26 +0900 Minchan Kim wrote: >> >>> Sergey reported VM_WARN_ON_ONCE returns void with !CONFIG_DEBUG_VM >>> so we cannot use it as if's condition un

Re: "mm: fix lazyfree BUG_ON check in try_to_unmap_one()" build error

2017-03-09 Thread Minchan Kim
Hi Andrew, On Thu, Mar 09, 2017 at 01:27:06PM -0800, Andrew Morton wrote: > On Thu, 9 Mar 2017 15:02:26 +0900 Minchan Kim wrote: > > > Sergey reported VM_WARN_ON_ONCE returns void with !CONFIG_DEBUG_VM > > so we cannot use it as if's condition unlike WARN_ON. > > Can we instead fix VM_WARN_ON_O

Re: "mm: fix lazyfree BUG_ON check in try_to_unmap_one()" build error

2017-03-09 Thread Andrew Morton
On Thu, 9 Mar 2017 15:02:26 +0900 Minchan Kim wrote: > Sergey reported VM_WARN_ON_ONCE returns void with !CONFIG_DEBUG_VM > so we cannot use it as if's condition unlike WARN_ON. Can we instead fix VM_WARN_ON_ONCE()?

Re: "mm: fix lazyfree BUG_ON check in try_to_unmap_one()" build error

2017-03-09 Thread Michal Hocko
On Thu 09-03-17 15:02:26, Minchan Kim wrote: [...] > >From 38b10e560d066c2cef8f9d028e14008cefdaa3e0 Mon Sep 17 00:00:00 2001 > From: Minchan Kim > Date: Thu, 9 Mar 2017 14:58:23 +0900 > Subject: [PATCH] mm: do not use VM_WARN_ON_ONCE as if condition > > Sergey reported VM_WARN_ON_ONCE returns voi

Re: "mm: fix lazyfree BUG_ON check in try_to_unmap_one()" build error

2017-03-08 Thread Minchan Kim
Hi Sergey, On Thu, Mar 09, 2017 at 01:29:08PM +0900, Sergey Senozhatsky wrote: > Hello Minchan, > > /* I can't https://marc.info/?l=linux-kernel&m=148886631303107 thread >in my mail box for some reason so the Reply-To message-id may be wrong. */ > > > > commit "mm: fix lazyfree BUG_ON chec