Re: [PATCH/RFC] kunit/rtc: Add real support for very slow tests

2025-03-28 Thread Geert Uytterhoeven
Hi David, On Fri, 28 Mar 2025 at 09:07, David Gow wrote: > Thanks for sending this out: I think this raises some good questions > about exactly how to handle long running tests (particularly on > older/slower hardware). > > I've put a few notes below, but, tl;dr: I think these are all good > chan

Re: [PATCH/RFC] kunit/rtc: Add real support for very slow tests

2025-03-28 Thread David Gow
r scale to slower hardware. On Fri, 28 Mar 2025 at 00:07, Geert Uytterhoeven wrote: > > When running rtc_lib_test ("lib_test" before my "[PATCH] rtc: Rename > lib_test to rtc_lib_test") on m68k/ARAnyM: > > KTAP version 1 > 1..1 > KTA

[PATCH/RFC] kunit/rtc: Add real support for very slow tests

2025-03-27 Thread Geert Uytterhoeven
When running rtc_lib_test ("lib_test" before my "[PATCH] rtc: Rename lib_test to rtc_lib_test") on m68k/ARAnyM: KTAP version 1 1..1 KTAP version 1 # Subtest: rtc_lib_test_cases # module: rtc_lib_test 1..2 # rtc_time64_to_tm_

[PATCH] rtc: Rename lib_test to rtc_lib_test

2025-03-27 Thread Geert Uytterhoeven
When compiling the RTC library functions test as a module, the module has the non-descriptive name "lib_test.ko". Fix this by adding the subsystem's name as a prefix. Signed-off-by: Geert Uytterhoeven --- drivers/rtc/Makefile | 2 +- drivers/

[PATCH v6 4/4] virtio_rtc: Add RTC class driver

2025-03-13 Thread Peter Hilber
Expose the virtio-rtc UTC-like clock as an RTC clock to userspace - if it is present, and if it does not step on leap seconds. The RTC class enables the virtio-rtc device to resume the system from sleep states on RTC alarm. Support RTC alarm if the virtio-rtc alarm feature is present. The virtio

[PATCH v5 4/4] virtio_rtc: Add RTC class driver

2025-02-19 Thread Peter Hilber
Expose the virtio-rtc UTC-like clock as an RTC clock to userspace - if it is present, and if it does not step on leap seconds. The RTC class enables the virtio-rtc device to resume the system from sleep states on RTC alarm. Support RTC alarm if the virtio-rtc alarm feature is present. The virtio

Re: [RFC PATCH v4 4/4] virtio_rtc: Add RTC class driver

2024-12-23 Thread Alexandre Belloni
On 19/12/2024 21:11:10+0100, Peter Hilber wrote: > Expose the virtio-rtc UTC-like clock as an RTC clock to userspace - if it > is present, and if it does not step on leap seconds. The RTC class enables > the virtio-rtc device to resume the system from sleep states on RTC alarm. > &

[RFC PATCH v4 4/4] virtio_rtc: Add RTC class driver

2024-12-19 Thread Peter Hilber
Expose the virtio-rtc UTC-like clock as an RTC clock to userspace - if it is present, and if it does not step on leap seconds. The RTC class enables the virtio-rtc device to resume the system from sleep states on RTC alarm. Support RTC alarm if the virtio-rtc alarm feature is present. The virtio

Re: (subset) [RFC PATCH v2 1/2] mfd: 88pm886: add the RTC cell

2024-11-12 Thread Lee Jones
On Sat, 12 Oct 2024 21:31:38 +0200, Karel Balej wrote: > Add a MFD cell for the chip's real-time clock. > > Applied, thanks! [1/2] mfd: 88pm886: add the RTC cell commit: 156d87b679a565a166da4a7ce892cb87f6317faf -- Lee Jones [李琼斯]

Re: [RFC PATCH v2 1/2] mfd: 88pm886: add the RTC cell

2024-11-11 Thread Karel Balej
Lee Jones, 2024-10-15T09:36:03+01:00: > On Sat, 12 Oct 2024, Karel Balej wrote: > > > Add a MFD cell for the chip's real-time clock. > > > > Signed-off-by: Karel Balej > > --- > > > > Notes: > > RFC v2: > > - Break out the register definitions and reword the commit message > > acco

Re: (subset) [RFC PATCH v2 2/2] rtc: add driver for Marvell 88PM886 PMIC RTC

2024-11-11 Thread Alexandre Belloni
On Sat, 12 Oct 2024 21:31:39 +0200, Karel Balej wrote: > RTC lives on the chip's base register page. Add the relevant register > definitions and implement a basic set/read time functionality. Tested > with the samsung,coreprimevelte smartphone which contains this PMIC and > wh

Re: [RFC PATCH v2 2/2] rtc: add driver for Marvell 88PM886 PMIC RTC

2024-11-11 Thread Alexandre Belloni
Lee, I'm happy taking this patch, I guess you are going to take 1/2 ? On 12/10/2024 21:31:39+0200, Karel Balej wrote: > RTC lives on the chip's base register page. Add the relevant register > definitions and implement a basic set/read time functionality. Tested > with the sam

Re: [PATCH v2 1/2] selftest: rtc: Add to check rtc alarm status for alarm related test

2024-10-23 Thread Shuah Khan
interface to check rtc alarm feature state before running alarm related tests. If the kernel does not support RTC_PARAM_GET ioctl interface, we will fallback to check the error number of (RTC_ALM_SET/RTC_WKALM_SET) ioctl call for alarm feature detection. Requires commit 101ca8d05913b ("rtc

Re: [PATCH v2 1/2] selftest: rtc: Add to check rtc alarm status for alarm related test

2024-10-22 Thread Alexandre Belloni
ign may miss detecting real problems when the > efi.set_wakeup_time() return errors and then RTC_ALM_SET/RTC_WKALM_SET > ioctl returns an EINVAL error code with RTC_FEATURE_ALARM enabled. > > In order to make rtctest more explicit and robust, we propose to use > RTC_PARAM_GET ioctl i

[PATCH v2 1/2] selftest: rtc: Add to check rtc alarm status for alarm related test

2024-10-20 Thread Joseph Jang
() return errors and then RTC_ALM_SET/RTC_WKALM_SET ioctl returns an EINVAL error code with RTC_FEATURE_ALARM enabled. In order to make rtctest more explicit and robust, we propose to use RTC_PARAM_GET ioctl interface to check rtc alarm feature state before running alarm related tests. If the kernel

Re: [PATCH 1/2] selftest: rtc: Add to check rtc alarm status for alarm related test

2024-10-18 Thread Shuah Khan
an EINVAL error code with RTC_FEATURE_ALARM enabled. In order to make rtctest more explicit and robust, we propose to use RTC_PARAM_GET ioctl interface to check rtc alarm feature state before running alarm related tests. If the kernel does not support RTC_PARAM_GET ioctl interface, we will

Re: [PATCH 2/2] selftest: rtc: Check if could access /dev/rtc0 before testing

2024-10-18 Thread Shuah Khan
On 10/17/24 22:18, Joseph Jang wrote: On 2024/9/25 3:57 AM, Shuah Khan wrote: On 9/24/24 13:31, Alexandre Belloni wrote: Hello, On 24/09/2024 10:05:43-0600, Shuah Khan wrote: On 9/23/24 23:37, Joseph Jang wrote: Hi Alexandre, Thank you for looking at the rtc patch. I saw you Acked the

Re: [PATCH 1/2] selftest: rtc: Add to check rtc alarm status for alarm related test

2024-10-18 Thread Alexandre Belloni
n the > > > > efi.set_wakeup_time() return errors and then RTC_ALM_SET/RTC_WKALM_SET > > > > ioctl returns an EINVAL error code with RTC_FEATURE_ALARM enabled. > > > > > > > > In order to make rtctest more explicit and robust, we propose to use >

Re: [PATCH 1/2] selftest: rtc: Add to check rtc alarm status for alarm related test

2024-10-17 Thread Joseph Jang
and robust, we propose to use RTC_PARAM_GET ioctl interface to check rtc alarm feature state before running alarm related tests. If the kernel does not support RTC_PARAM_GET ioctl interface, we will fallback to check the error number of (RTC_ALM_SET/RTC_WKALM_SET) ioctl call for alarm feature

Re: [PATCH 2/2] selftest: rtc: Check if could access /dev/rtc0 before testing

2024-10-17 Thread Joseph Jang
On 2024/9/25 3:57 AM, Shuah Khan wrote: On 9/24/24 13:31, Alexandre Belloni wrote: Hello, On 24/09/2024 10:05:43-0600, Shuah Khan wrote: On 9/23/24 23:37, Joseph Jang wrote: Hi Alexandre, Thank you for looking at the rtc patch. I saw you Acked the [PATCH 2/2], not sure when could we see

Re: [RFC PATCH v2 1/2] mfd: 88pm886: add the RTC cell

2024-10-15 Thread Lee Jones
9efc027d2..891fdce5d8c1 100644 > --- a/drivers/mfd/88pm886.c > +++ b/drivers/mfd/88pm886.c > @@ -37,6 +37,7 @@ static struct resource pm886_onkey_resources[] = { > static struct mfd_cell pm886_devs[] = { > MFD_CELL_RES("88pm886-onkey", pm886_onkey_resourc

Re: [RFC PATCH v2 2/2] rtc: add driver for Marvell 88PM886 PMIC RTC

2024-10-15 Thread Lee Jones
On Sat, 12 Oct 2024, Karel Balej wrote: > RTC lives on the chip's base register page. Add the relevant register > definitions and implement a basic set/read time functionality. Tested > with the samsung,coreprimevelte smartphone which contains this PMIC and > whose vendor ker

[RFC PATCH v2 2/2] rtc: add driver for Marvell 88PM886 PMIC RTC

2024-10-12 Thread Karel Balej
RTC lives on the chip's base register page. Add the relevant register definitions and implement a basic set/read time functionality. Tested with the samsung,coreprimevelte smartphone which contains this PMIC and whose vendor kernel tree has also served as the sole reference for this. Signe

[RFC PATCH v2 1/2] mfd: 88pm886: add the RTC cell

2024-10-12 Thread Karel Balej
_devs[] = { MFD_CELL_RES("88pm886-onkey", pm886_onkey_resources), MFD_CELL_NAME("88pm886-regulator"), + MFD_CELL_NAME("88pm886-rtc"), }; static int pm886_power_off_handler(struct sys_off_data *sys_off_data) -- 2.47.0

Re: (subset) [RFC PATCH 1/2] mfd: 88pm886: add the RTC cell and relevant definitions

2024-10-11 Thread Lee Jones
; > On Fri, 20 Sep 2024 18:12:34 +0200, Karel Balej wrote: > > > > > > RTC lives on the base register page of the chip. Add definitions of > > > > > > the > > > > > > registers needed for a basic set/read time functionality. > &g

Re: (subset) [RFC PATCH 1/2] mfd: 88pm886: add the RTC cell and relevant definitions

2024-10-10 Thread Karel Balej
Lee Jones, 2024-10-10T09:35:19+01:00: > On Thu, 10 Oct 2024, Lee Jones wrote: > > > On Wed, 09 Oct 2024, Karel Balej wrote: > > > > > Lee Jones, 2024-10-09T11:06:43+01:00: > > > > On Fri, 20 Sep 2024 18:12:34 +0200, Karel Balej wrote: > > > > >

Re: (subset) [RFC PATCH 1/2] mfd: 88pm886: add the RTC cell and relevant definitions

2024-10-10 Thread Lee Jones
On Wed, 09 Oct 2024, Lee Jones wrote: > On Fri, 20 Sep 2024 18:12:34 +0200, Karel Balej wrote: > > RTC lives on the base register page of the chip. Add definitions of the > > registers needed for a basic set/read time functionality. > > > > > > Applied, thanks!

Re: (subset) [RFC PATCH 1/2] mfd: 88pm886: add the RTC cell and relevant definitions

2024-10-10 Thread Lee Jones
On Thu, 10 Oct 2024, Lee Jones wrote: > On Wed, 09 Oct 2024, Karel Balej wrote: > > > Lee Jones, 2024-10-09T11:06:43+01:00: > > > On Fri, 20 Sep 2024 18:12:34 +0200, Karel Balej wrote: > > > > RTC lives on the base register page of the chip. Add definitions of t

Re: (subset) [RFC PATCH 1/2] mfd: 88pm886: add the RTC cell and relevant definitions

2024-10-10 Thread Lee Jones
On Wed, 09 Oct 2024, Karel Balej wrote: > Lee Jones, 2024-10-09T11:06:43+01:00: > > On Fri, 20 Sep 2024 18:12:34 +0200, Karel Balej wrote: > > > RTC lives on the base register page of the chip. Add definitions of the > > > registers needed for a basic

Re: (subset) [RFC PATCH 1/2] mfd: 88pm886: add the RTC cell and relevant definitions

2024-10-09 Thread Karel Balej
Lee Jones, 2024-10-09T11:06:43+01:00: > On Fri, 20 Sep 2024 18:12:34 +0200, Karel Balej wrote: > > RTC lives on the base register page of the chip. Add definitions of the > > registers needed for a basic set/read time functionality. > > > > > > Applied, thanks!

Re: (subset) [RFC PATCH 1/2] mfd: 88pm886: add the RTC cell and relevant definitions

2024-10-09 Thread Lee Jones
On Fri, 20 Sep 2024 18:12:34 +0200, Karel Balej wrote: > RTC lives on the base register page of the chip. Add definitions of the > registers needed for a basic set/read time functionality. > > Applied, thanks! [1/2] mfd: 88pm886: add the RTC cell and relevant definitions

Re: [PATCH 2/2] selftest: rtc: Check if could access /dev/rtc0 before testing

2024-09-24 Thread Shuah Khan
On 9/24/24 13:31, Alexandre Belloni wrote: Hello, On 24/09/2024 10:05:43-0600, Shuah Khan wrote: On 9/23/24 23:37, Joseph Jang wrote: Hi Alexandre, Thank you for looking at the rtc patch. I saw you Acked the [PATCH 2/2], not sure when could we see the patch in kernel master or next branch

Re: [PATCH 2/2] selftest: rtc: Check if could access /dev/rtc0 before testing

2024-09-24 Thread Alexandre Belloni
Hello, On 24/09/2024 10:05:43-0600, Shuah Khan wrote: > On 9/23/24 23:37, Joseph Jang wrote: > > Hi Alexandre, > > > > Thank you for looking at the rtc patch. > > I saw you Acked the [PATCH 2/2], not sure when could we see the patch > > in kernel master or

Re: [PATCH 2/2] selftest: rtc: Check if could access /dev/rtc0 before testing

2024-09-24 Thread Shuah Khan
On 9/23/24 23:37, Joseph Jang wrote: Hi Alexandre, Thank you for looking at the rtc patch. I saw you Acked the [PATCH 2/2], not sure when could we see the patch in kernel master or next branch ? Thank you, Joseph. Please don't top post. It is hard to follow the thread. On 2024/6/21

Re: [PATCH 2/2] selftest: rtc: Check if could access /dev/rtc0 before testing

2024-09-23 Thread Joseph Jang
Hi Alexandre, Thank you for looking at the rtc patch. I saw you Acked the [PATCH 2/2], not sure when could we see the patch in kernel master or next branch ? Thank you, Joseph. On 2024/6/21 3:37 AM, Alexandre Belloni wrote: On 23/05/2024 18:38:07-0700, Joseph Jang wrote: The rtctest requires

[RFC PATCH 1/2] mfd: 88pm886: add the RTC cell and relevant definitions

2024-09-20 Thread Karel Balej
RTC lives on the base register page of the chip. Add definitions of the registers needed for a basic set/read time functionality. Signed-off-by: Karel Balej --- drivers/mfd/88pm886.c | 1 + include/linux/mfd/88pm886.h | 9 + 2 files changed, 10 insertions(+) diff --git a/drivers

[RFC PATCH 2/2] rtc: add driver for Marvell 88PM886 PMIC RTC

2024-09-20 Thread Karel Balej
Only basic set/read time functionality is supported at the moment. Tested with the samsung,coreprimevelte smartphone which contains this PMIC and whose vendor kernel tree has also served as the sole reference for this. Signed-off-by: Karel Balej --- MAINTAINERS | 1 + drivers/rtc

Re: [RFC PATCH v3 7/7] virtio_rtc: Add RTC class driver

2024-03-13 Thread Peter Hilber
On 11.03.24 20:46, Alexandre Belloni wrote: > On 11/03/2024 19:28:50+0100, Peter Hilber wrote: >>>> Perhaps this might be handled by the driver also setting a virtio-rtc >>>> monotonic alarm (which uses a clock similar to CLOCK_BOOTTIME_ALARM). >>>> The >

Re: [RFC PATCH v3 7/7] virtio_rtc: Add RTC class driver

2024-03-11 Thread Alexandre Belloni
On 11/03/2024 19:28:50+0100, Peter Hilber wrote: > >> Perhaps this might be handled by the driver also setting a virtio-rtc > >> monotonic alarm (which uses a clock similar to CLOCK_BOOTTIME_ALARM). > >> The > >> virtio-rtc monotonic alarm would just be u

Re: [RFC PATCH v3 7/7] virtio_rtc: Add RTC class driver

2024-03-11 Thread Peter Hilber
On 08.03.24 18:03, Alexandre Belloni wrote: > Hello, > > I'll start by saying that I'm sorry, I have a very very high level > knowledge about what virtio is. > > On 18/12/2023 08:38:45+0100, Peter Hilber wrote: >> Expose the virtio-rtc UTC clock as an RTC clock

Re: [RFC PATCH v3 7/7] virtio_rtc: Add RTC class driver

2024-03-08 Thread Alexandre Belloni
Hello, I'll start by saying that I'm sorry, I have a very very high level knowledge about what virtio is. On 18/12/2023 08:38:45+0100, Peter Hilber wrote: > Expose the virtio-rtc UTC clock as an RTC clock to userspace, if it is > present. Support RTC alarm if the virtio-rtc

[RFC PATCH v3 7/7] virtio_rtc: Add RTC class driver

2023-12-17 Thread Peter Hilber
Expose the virtio-rtc UTC clock as an RTC clock to userspace, if it is present. Support RTC alarm if the virtio-rtc alarm feature is present. The virtio-rtc device signals an alarm by marking an alarmq buffer as used. Peculiarities - A virtio-rtc clock is a bit special for an RTC

[PATCH 7/9] rtc: s5m: Remove reference to parent's device pdata

2021-04-20 Thread Krzysztof Kozlowski
The S5M RTC driver does not use parent's device (sec-core PMIC driver) platform data so there is no need to check for it. Signed-off-by: Krzysztof Kozlowski --- drivers/rtc/rtc-s5m.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c

[PATCH 0/9] mfd/rtc/regulator: Drop board file support for Samsung PMIC

2021-04-20 Thread Krzysztof Kozlowski
pieces are rebased on my previous sec-core dirver changes: mfd: sec: Simplify getting of_device_id match data https://lore.kernel.org/linux-samsung-soc/20210420113929.278082-1-krzysztof.kozlow...@canonical.com/T/#t Applying - can be independent = The last RTC and regulator

Re: [PATCH 1/1] rtc: pcf85063: add integrity check

2021-04-19 Thread Alexandre Belloni
On 19/04/2021 20:26:42+, Gervais, Francois wrote: > > I'm not sure I get the use case because PCF85063_REG_CTRL2 should be > > initialized properly after the driver is probed anyway. The other two > > can be set from userspace once it detects the oscillator failure which > > would be better at

Re: [PATCH 1/1] rtc: pcf85063: add integrity check

2021-04-19 Thread Gervais, Francois
> I'm not sure I get the use case because PCF85063_REG_CTRL2 should be > initialized properly after the driver is probed anyway. The other two > can be set from userspace once it detects the oscillator failure which > would be better at deciding the policy anyway. Thank you for the feedback I thin

[PATCH] rtc: sun6i: Add NVMEM provider

2021-04-18 Thread Samuel Holland
The sun6i RTC provides 32 bytes of general-purpose data registers. They can be used to save data in the always-on RTC power domain. The registers are writable via 32-bit MMIO accesses only. Expose the region as a NVMEM provider so it can be used by userspace and other drivers. Signed-off-by

[PATCH 2/3] rtc: pcf8523: add alarm support

2021-04-17 Thread Alexandre Belloni
Alarm support requires unconditionally disabling clock out because it is using the int1 pin. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf8523.c | 181 +- 1 file changed, 180 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf8523.c b

[PATCH 3/3] rtc: pcf8523: report oscillator failures

2021-04-17 Thread Alexandre Belloni
Report oscillator failures and invalid date/time on RTC_VL_READ. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf8523.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c index feadab8e3bd3

[PATCH 1/3] rtc: pcf8523: remove useless define

2021-04-17 Thread Alexandre Belloni
Drop DRIVER_NAME as it is only used once Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf8523.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c index 5e1e7b2a8c9a..fe3ab41d8326 100644 --- a/drivers/rtc/rtc

[PATCH v2 3/3] rtc: rtc_update_irq_enable: rework UIE emulation

2021-04-17 Thread Alexandre Belloni
of __rtc_set_alarm anymore. Tested-by: Łukasz Stelmach Signed-off-by: Alexandre Belloni --- Changes in v2: - Fix possible deadlock when using UIE emulation (no impact on Łukasz' test) - Remove rc drivers/rtc/interface.c | 34 ++ 1 file changed, 10 inser

[PATCH v2 2/3] rtc: ds1307: remove flags

2021-04-17 Thread Alexandre Belloni
flags is now unused, drop it. Tested-by: Łukasz Stelmach Reviewed-by: Łukasz Stelmach Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds1307.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index 76d67c419f7d..089509d0a3a0 100644

[PATCH v2 1/3] rtc: ds1307: replace HAS_ALARM by RTC_FEATURE_ALARM

2021-04-17 Thread Alexandre Belloni
The core now has RTC_FEATURE_ALARM for the driver to indicate whether alarms are available. Use that instead of HAS_ALARM to ensure the alarm callbacks are not even called. Tested-by: Łukasz Stelmach Reviewed-by: Łukasz Stelmach Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds1307.c

Re: [PATCH] rtc: remove unused function

2021-04-16 Thread Alexandre Belloni
On Thu, 15 Apr 2021 16:37:01 +0800, Jiapeng Chong wrote: > Fix the following clang warning: > > drivers/rtc/rtc-ds1511.c:108:1: warning: unused function > 'rtc_write_alarm' [-Wunused-function]. Applied, thanks! [1/1] rtc: remove unused

Re: [PATCH] rtc: fsl-ftm-alarm: add MODULE_TABLE()

2021-04-16 Thread Alexandre Belloni
On Wed, 14 Apr 2021 10:40:06 +0200, Michael Walle wrote: > The module doesn't load automatically. Fix it by adding the missing > MODULE_TABLE(). Applied, thanks! [1/1] rtc: fsl-ftm-alarm: add MODULE_TABLE() commit: 199bb382375ad1b2178e250f82f6d95f8d6f7709 Best regards, --

Re: (subset) [PATCH V2 0/4] Add RTC support for PMIC PMK8350

2021-04-16 Thread Alexandre Belloni
On Fri, 9 Apr 2021 19:29:22 +0530, satya priya wrote: > satya priya (4): > rtc: pm8xxx: Add RTC support for PMIC PMK8350 > dt-bindings: mfd: Add compatible for pmk8350 rtc > dt-bindings: mfd: Convert pm8xxx bindings to yaml > dt-bindings: rtc: qcom-pm8xxx-rtc: Add qcom pm8x

Re: [PATCH 1/1] rtc: pcf85063: fallback to parent of_node

2021-04-16 Thread Alexandre Belloni
On Wed, 10 Mar 2021 16:10:26 -0500, Francois Gervais wrote: > The rtc device node is always or at the very least can possibly be NULL. > > Since v5.12-rc1-dontuse/3c9ea42802a1fbf7ef29660ff8c6e526c58114f6 this > will lead to a NULL pointer dereference. > > To fix this we fal

Re: [PATCH 1/1] rtc: pcf85063: add integrity check

2021-04-16 Thread Alexandre Belloni
Hi, On 11/03/2021 12:49:40-0500, Francois Gervais wrote: > Sometimes when the RTC battery is inserted, the voltage will bounce a > bit and we've seen that this can randomly flip configuration bits in > the RTC. > > For example, we've seen COF bits flips and then the

Re: [PATCH] rtc: Fix missing IRQF_ONESHOT as only threaded handler

2021-04-16 Thread Krzysztof Kozlowski
On 16/04/2021 04:19, zhuguangqin...@gmail.com wrote: > From: Guangqing Zhu > > Coccinelle noticed: > 1. drivers/rtc/rtc-s5m.c:810:7-32: ERROR: Threaded IRQ with no primary >handler requested without IRQF_ONESHOT > 2. drivers/rtc/rtc-rk808.c:441:7-32: ERROR: Threaded I

Re: [PATCH] rtc: Fix missing IRQF_ONESHOT as only threaded handler

2021-04-16 Thread Krzysztof Kozlowski
On 16/04/2021 04:19, zhuguangqin...@gmail.com wrote: > From: Guangqing Zhu > > Coccinelle noticed: > 1. drivers/rtc/rtc-s5m.c:810:7-32: ERROR: Threaded IRQ with no primary >handler requested without IRQF_ONESHOT > 2. drivers/rtc/rtc-rk808.c:441:7-32: ERROR: Threaded I

[PATCH] rtc: Fix missing IRQF_ONESHOT as only threaded handler

2021-04-15 Thread zhuguangqing83
From: Guangqing Zhu Coccinelle noticed: 1. drivers/rtc/rtc-s5m.c:810:7-32: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT 2. drivers/rtc/rtc-rk808.c:441:7-32: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT 3. drivers/rtc/rtc-max77686

[PATCH] rtc: remove unused function

2021-04-15 Thread Jiapeng Chong
Fix the following clang warning: drivers/rtc/rtc-ds1511.c:108:1: warning: unused function 'rtc_write_alarm' [-Wunused-function]. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/rtc/rtc-ds1511.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/rtc/rt

Re: [GIT PULL] Immutable branch between MFD, Clock, GPIO, Regulator and RTC due for the v5.13 merge window

2021-04-14 Thread Lee Jones
; Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) > > > > > > are available in the Git repository at: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git > > > tags/i

Re: [GIT PULL] Immutable branch between MFD, Clock, GPIO, Regulator and RTC due for the v5.13 merge window

2021-04-14 Thread Vaittinen, Matti
t your peril! :) > > > > The following changes since commit > > a38fd8748464831584a19438cbb3082b5a2dab15: > > > > Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/

Re: [GIT PULL] Immutable branch between MFD, Clock, GPIO, Regulator and RTC due for the v5.13 merge window

2021-04-14 Thread Lee Jones
> > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git > tags/ib-mfd-clk-gpio-regulator-rtc-v5.13 > > for you to fetch changes up to 5a8a64d9a38b9d3794f9f5e153fc0358b858cc24: > > MA

[GIT PULL] Immutable branch between MFD, Clock, GPIO, Regulator and RTC due for the v5.13 merge window

2021-04-14 Thread Lee Jones
a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git tags/ib-mfd-clk-gpio-regulator-rtc-v5.13 for you to fetch changes up to 5a8a64d9a38b9d3794f9f5e153fc0358b858cc24

[PATCH] rtc: fsl-ftm-alarm: add MODULE_TABLE()

2021-04-14 Thread Michael Walle
The module doesn't load automatically. Fix it by adding the missing MODULE_TABLE(). Fixes: 7b0b551dbc1e ("rtc: fsl-ftm-alarm: add FTM alarm driver") Signed-off-by: Michael Walle --- drivers/rtc/rtc-fsl-ftm-alarm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/

Re: [PATCH V2 2/4] dt-bindings: mfd: Add compatible for pmk8350 rtc

2021-04-14 Thread Lee Jones
On Fri, 09 Apr 2021, satya priya wrote: > Add compatible string for pmk8350 rtc support. > > Signed-off-by: satya priya > Reviewed-by: Bjorn Andersson > --- > Changes in V2: > - Moved this patch before conversion patches. > > Documentation/devicetree/bindings/mfd

Re: [PATCH V2 0/4] Add RTC support for PMIC PMK8350

2021-04-13 Thread Alexandre Belloni
Lee, On 09/04/2021 19:29:22+0530, satya priya wrote: > satya priya (4): > rtc: pm8xxx: Add RTC support for PMIC PMK8350 > dt-bindings: mfd: Add compatible for pmk8350 rtc > dt-bindings: mfd: Convert pm8xxx bindings to yaml > dt-bindings: rtc: qcom-pm8xxx-rtc: Add qcom pm8x

Re: [PATCH V2 4/4] dt-bindings: rtc: qcom-pm8xxx-rtc: Add qcom pm8xxx rtc bindings

2021-04-12 Thread Rob Herring
On Fri, 09 Apr 2021 19:29:26 +0530, satya priya wrote: > Add binding doc for qcom pm8xxx rtc device. > > Signed-off-by: satya priya > --- > Changes in V2: > - Added this in V2 to have separate binding for rtc node. > > .../devicetree/bindings/rtc/qco

Re: [PATCH V2 2/4] dt-bindings: mfd: Add compatible for pmk8350 rtc

2021-04-12 Thread Rob Herring
On Fri, 09 Apr 2021 19:29:24 +0530, satya priya wrote: > Add compatible string for pmk8350 rtc support. > > Signed-off-by: satya priya > Reviewed-by: Bjorn Andersson > --- > Changes in V2: > - Moved this patch before conversion patches. > > Documentation/d

Re: [PATCH V2 4/4] dt-bindings: rtc: qcom-pm8xxx-rtc: Add qcom pm8xxx rtc bindings

2021-04-11 Thread kernel test robot
Hi satya, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on abelloni/rtc-next] [also build test WARNING on lee-mfd/for-mfd-next robh/for-next v5.12-rc6 next-20210409] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH V2 4/4] dt-bindings: rtc: qcom-pm8xxx-rtc: Add qcom pm8xxx rtc bindings

2021-04-09 Thread Bjorn Andersson
On Fri 09 Apr 08:59 CDT 2021, satya priya wrote: > Add binding doc for qcom pm8xxx rtc device. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: satya priya > --- > Changes in V2: > - Added this in V2 to have separate binding for rtc node. > > ...

[PATCH V2 1/4] rtc: pm8xxx: Add RTC support for PMIC PMK8350

2021-04-09 Thread satya priya
Add the comaptible string for PMIC PMK8350. Signed-off-by: satya priya Reviewed-by: Bjorn Andersson --- Chnges in V2: - No change. drivers/rtc/rtc-pm8xxx.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c index eb20659

[PATCH V2 2/4] dt-bindings: mfd: Add compatible for pmk8350 rtc

2021-04-09 Thread satya priya
Add compatible string for pmk8350 rtc support. Signed-off-by: satya priya Reviewed-by: Bjorn Andersson --- Changes in V2: - Moved this patch before conversion patches. Documentation/devicetree/bindings/mfd/qcom-pm8xxx.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation

[PATCH V2 0/4] Add RTC support for PMIC PMK8350

2021-04-09 Thread satya priya
satya priya (4): rtc: pm8xxx: Add RTC support for PMIC PMK8350 dt-bindings: mfd: Add compatible for pmk8350 rtc dt-bindings: mfd: Convert pm8xxx bindings to yaml dt-bindings: rtc: qcom-pm8xxx-rtc: Add qcom pm8xxx rtc bindings .../devicetree/bindings/mfd/qcom-pm8xxx.txt| 99

[PATCH V2 4/4] dt-bindings: rtc: qcom-pm8xxx-rtc: Add qcom pm8xxx rtc bindings

2021-04-09 Thread satya priya
Add binding doc for qcom pm8xxx rtc device. Signed-off-by: satya priya --- Changes in V2: - Added this in V2 to have separate binding for rtc node. .../devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml | 62 ++ 1 file changed, 62 insertions(+) create mode 100644

[PATCH v6 15/16] rtc: bd70528: Support RTC on ROHM BD71815

2021-04-05 Thread Matti Vaittinen
BD71815 contains similar RTC block as BD71828. Only the address offsets seem different. Support also BD71815 RTC using rtc-bd70528. Signed-off-by: Matti Vaittinen Acked-by: Alexandre Belloni --- Changes since v3: - No changes drivers/rtc/Kconfig | 6 +++--- drivers/rtc/rtc-bd70528.c

[PATCH v6 01/16] rtc: bd70528: Do not require parent data

2021-04-05 Thread Matti Vaittinen
The ROHM BD71828 and BD71815 RTC drivers only need the regmap pointer from parent. Regmap can be obtained via dev_get_regmap() so do not require parent to populate driver data for that. BD70528 on the other hand requires parent data to access the watchdog so leave the parent data for BD70528 here

Re: [PATCH 3/3] rtc: rtc_update_irq_enable: rework UIE emulation

2021-04-02 Thread Łukasz Stelmach
because there is now only one > error value to track and is not relying on the return value of > __rtc_set_alarm anymore. > > Signed-off-by: Alexandre Belloni > --- > drivers/rtc/interface.c | 28 +++- > 1 file changed, 7 insertions(+), 21 deletions

Re: [PATCH 2/3] rtc: ds1307: remove flags

2021-04-02 Thread Łukasz Stelmach
It was <2021-03-30 wto 02:03>, when Alexandre Belloni wrote: > flags is now unused, drop it. > > Signed-off-by: Alexandre Belloni > --- > drivers/rtc/rtc-ds1307.c | 2 -- > 1 file changed, 2 deletions(-) > Tested-by: Łukasz Stelmach Reviewed-by: Łukasz Stelmach >

Re: [PATCH 1/3] rtc: ds1307: replace HAS_ALARM by RTC_FEATURE_ALARM

2021-04-02 Thread Łukasz Stelmach
It was <2021-03-30 wto 02:03>, when Alexandre Belloni wrote: > The core now has RTC_FEATURE_ALARM for the driver to indicate whether > alarms are available. Use that instead of HAS_ALARM to ensure the alarm > callbacks are not even called. > > Signed-off-by: Alexandre Belloni

[PATCH v7 2/8] rtc: mt6397: refine RTC_TC_MTH

2021-03-31 Thread Hsin-Hsiung Wang
This patch adds RTC_TC_MTH_MASK to support new chips. Signed-off-by: Yuchen Huang Signed-off-by: Hsin-Hsiung Wang Acked-by: Alexandre Belloni --- changes since v6: - no change. --- drivers/rtc/rtc-mt6397.c | 2 +- include/linux/mfd/mt6397/rtc.h | 1 + 2 files changed, 2 insertions(+), 1

Re: [PATCH 2/4] rtc: abx80x: Enable SQW output

2021-03-30 Thread Kirill Kapranov
tware Engineer CompuLab Ltd. [1] https://marc.info/?l=linux-rtc&m=161696606727215&w=2 On 3/29/21 9:19 AM, Dan Carpenter wrote: Hi Kirill, url: https://github.com/0day-ci/linux/commits/Kirill-Kapranov/rtc-abx80x-Enable-distributed-digital-calibration/20210329-053233 base: https://git.kerne

Re: [PATCH] rtc: ds1307: set uie_unsupported if no interrupt is available

2021-03-29 Thread Lukasz Stelmach
It was <2021-03-30 wto 02:02>, when Alexandre Belloni wrote: > On 16/03/2021 19:04:14+0100, Lukasz Stelmach wrote: >> OK, you are right. The problem seems to be elsewhere. >> >> How about this scnario? We call rtc_update_irq_enable(). We read rtc >> with __rtc_re

[PATCH 3/3] rtc: rtc_update_irq_enable: rework UIE emulation

2021-03-29 Thread Alexandre Belloni
of __rtc_set_alarm anymore. Signed-off-by: Alexandre Belloni --- drivers/rtc/interface.c | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c index dcb34c73319e..b162964d2b39 100644 --- a/drivers/rtc

[PATCH 2/3] rtc: ds1307: remove flags

2021-03-29 Thread Alexandre Belloni
flags is now unused, drop it. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds1307.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index 76d67c419f7d..089509d0a3a0 100644 --- a/drivers/rtc/rtc-ds1307.c +++ b/drivers/rtc/rtc

[PATCH 1/3] rtc: ds1307: replace HAS_ALARM by RTC_FEATURE_ALARM

2021-03-29 Thread Alexandre Belloni
The core now has RTC_FEATURE_ALARM for the driver to indicate whether alarms are available. Use that instead of HAS_ALARM to ensure the alarm callbacks are not even called. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds1307.c | 42 +++- 1 file

Re: [PATCH] rtc: ds1307: set uie_unsupported if no interrupt is available

2021-03-29 Thread Alexandre Belloni
On 16/03/2021 19:04:14+0100, Lukasz Stelmach wrote: > OK, you are right. The problem seems to be elsewhere. > > How about this scnario? We call rtc_update_irq_enable(). We read rtc > with __rtc_read_time() and calculate the alarm time. We get through > rtc_timer_enqueu

[PATCH v5 18/19] rtc: bd70528: Support RTC on ROHM BD71815

2021-03-29 Thread Matti Vaittinen
BD71815 contains similar RTC block as BD71828. Only the address offsets seem different. Support also BD71815 RTC using rtc-bd70528. Signed-off-by: Matti Vaittinen Acked-by: Alexandre Belloni --- Changes since v3: - No changes drivers/rtc/Kconfig | 6 +++--- drivers/rtc/rtc-bd70528.c

[PATCH v5 01/19] rtc: bd70528: Do not require parent data

2021-03-29 Thread Matti Vaittinen
The ROHM BD71828 and BD71815 RTC drivers only need the regmap pointer from parent. Regmap can be obtained via dev_get_regmap() so do not require parent to populate driver data for that. BD70528 on the other hand requires parent data to access the watchdog so leave the parent data for BD70528 here

Re: [PATCH 2/4] rtc: abx80x: Enable SQW output

2021-03-28 Thread Dan Carpenter
Hi Kirill, url: https://github.com/0day-ci/linux/commits/Kirill-Kapranov/rtc-abx80x-Enable-distributed-digital-calibration/20210329-053233 base: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next config: i386-randconfig-m021-20210328 (attached as .config) compiler

Re: [PATCH 1/2] arm64: dts: ls1028a: move rtc alias to individual boards

2021-03-28 Thread Shawn Guo
On Tue, Mar 23, 2021 at 04:07:56PM +0100, Michael Walle wrote: > The aliases are board-specific and shouldn't be included in the common > SoC dtsi. Move them over to the boards. > > Signed-off-by: Michael Walle Applied both, thanks.

Re: [PATCH 2/4] rtc: abx80x: Enable SQW output

2021-03-28 Thread kernel test robot
Hi Kirill, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on abelloni/rtc-next] [also build test WARNING on v5.12-rc5 next-20210326] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

[PATCH 3/4] dt-bindings: rtc: abracon,abx80x: Add xt-frequency property

2021-03-28 Thread Kirill Kapranov
Add the string property "xt-frequency" to control xtal calibration of the RTC. This allows to improve the RTC accuracy using a Distributed Digital Calibration function. See: ch. 5.9.1 of AB08XX Series Ultra Low Power RTC IC User's Guide https://abracon.com/realtimeclock/AB0

[PATCH 1/4] dt-bindings: rtc: abracon,abx80x: Add sqw property

2021-03-28 Thread Kirill Kapranov
Introduce the string property "sqw" to control Square Wave Output register. This enables pulse generation output, that is useful for xtal calibration or for an external usage. Signed-off-by: Kirill Kapranov --- Documentation/devicetree/bindings/rtc/abracon,abx80x.txt | 12 ++

[PATCH 2/4] rtc: abx80x: Enable SQW output

2021-03-28 Thread Kirill Kapranov
The RTCs of the family are able to produce square wave output for RTC calibration purposes or for an external usage. Signed-off-by: Kirill Kapranov --- drivers/rtc/rtc-abx80x.c | 126 +++ 1 file changed, 126 insertions(+) diff --git a/drivers/rtc/rtc

[PATCH v4 15/16] rtc: bd70528: Support RTC on ROHM BD71815

2021-03-24 Thread Matti Vaittinen
BD71815 contains similar RTC block as BD71828. Only the address offsets seem different. Support also BD71815 RTC using rtc-bd70528. Signed-off-by: Matti Vaittinen Acked-by: Alexandre Belloni --- Changes since v3: - No changes drivers/rtc/Kconfig | 6 +++--- drivers/rtc/rtc-bd70528.c

[PATCH v4 01/16] rtc: bd70528: Do not require parent data

2021-03-24 Thread Matti Vaittinen
The ROHM BD71828 and BD71815 RTC drivers only need the regmap pointer from parent. Regmap can be obtained via dev_get_regmap() so do not require parent to populate driver data for that. BD70528 on the other hand requires parent data to access the watchdog so leave the parent data for BD70528 here

[PATCH 1/2] rtc: goldfish: remove dependency to OF

2021-03-23 Thread Laurent Vivier
We want to use the goldfish RTC on a machine without OF. As there is no real dependency on it, remove the OF dependency from the goldfish entry in Kconfig Signed-off-by: Laurent Vivier --- drivers/rtc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc

  1   2   3   4   5   6   7   8   9   10   >