Re: RFC arch/sh/kernel/traps_64.c - unclear if/else construct (hpux compat layer)

2015-02-17 Thread Helge Deller
H Paul, On 17.02.2015 09:49, Paul Bolle wrote: On Mon, 2015-02-16 at 22:24 +0100, Helge Deller wrote: The hpux code is broken anyway. I'm going to remove it from the tree. That happened in commit 04c161497716 ("parisc: hpux - Drop support for HP-UX binaries"), which is included in today's lin

Re: RFC arch/sh/kernel/traps_64.c - unclear if/else construct (hpux compat layer)

2015-02-17 Thread Paul Bolle
Hi Helge, On Mon, 2015-02-16 at 22:24 +0100, Helge Deller wrote: > The hpux code is broken anyway. > I'm going to remove it from the tree. That happened in commit 04c161497716 ("parisc: hpux - Drop support for HP-UX binaries"), which is included in today's linux-next (next-20150217). I noticed be

Re: RFC arch/sh/kernel/traps_64.c - unclear if/else construct (hpux compat layer)

2015-02-16 Thread Helge Deller
Hello Nicholas, On 03.02.2015 10:37, Nicholas Mc Guire wrote: scanning for if STATEMENT else STATEMENT triggered here - and it does look like it needs a fix-up or at least some comments. The if-else here has no effect and the printk will not convey any information as its always fstype==

RFC arch/sh/kernel/traps_64.c - unclear if/else construct

2015-02-03 Thread Nicholas Mc Guire
Hi ! scanning for if STATEMENT else STATEMENT triggered here - and it does look like it needs a fix-up or at least some comments. The if-else here has no effect and the printk will not convey any information as its always fstype==0, finally the return statement comment indicates that it sh