Re: RFC: Bug in error handling in gpiolib.c

2013-08-30 Thread Guenter Roeck
On 08/27/2013 12:17 PM, Tim Bird wrote: Hi all, There appears to be a bug in the error handling in drivers/gpi/gpiolib.c In certain error cases desc_to_gpio() is called to get the gpio number for an error message, but this may happen on code paths where desc->chip is NULL. This causes a panic

Re: RFC: Bug in error handling in gpiolib.c

2013-08-29 Thread Alexandre Courbot
On Fri, Aug 30, 2013 at 2:45 AM, Linus Walleij wrote: > On Tue, Aug 27, 2013 at 9:17 PM, Tim Bird wrote: > >> Hi all, >> >> There appears to be a bug in the error handling in >> drivers/gpi/gpiolib.c In certain error cases >> desc_to_gpio() is called to get the gpio number >> for an error messag

Re: RFC: Bug in error handling in gpiolib.c

2013-08-29 Thread Linus Walleij
On Tue, Aug 27, 2013 at 9:17 PM, Tim Bird wrote: > Hi all, > > There appears to be a bug in the error handling in > drivers/gpi/gpiolib.c In certain error cases > desc_to_gpio() is called to get the gpio number > for an error message, but this may happen on code > paths where desc->chip is NULL.

RFC: Bug in error handling in gpiolib.c

2013-08-27 Thread Tim Bird
Hi all, There appears to be a bug in the error handling in drivers/gpi/gpiolib.c In certain error cases desc_to_gpio() is called to get the gpio number for an error message, but this may happen on code paths where desc->chip is NULL. This causes a panic on my system in gpiod_request(), as follow