Re: RFC: "SubmittingPatches" text

2000-11-18 Thread Werner Almesberger
Rogier Wolff wrote: > I'd say DO CC Linux-kernel, don't CC Linus. Agreed. Posting to linux-kernel (as opposed to only the maintainer and/or Linus) serves the following purposes: - For patches introducing new features or changing existing ones, this exposes them to public review. (Every once

Re: RFC: "SubmittingPatches" text

2000-11-18 Thread Rogier Wolff
Andries Brouwer wrote: > On Fri, Nov 17, 2000 at 09:30:13AM +0100, Kai Germaschewski wrote: > > > One question comes to my mind: Are patches supposed to be applied with > > patch -p0 or patch -p1? > > Suppose the kernel tree is in /kernpath, starting with /kernpath/linux. > Linus' patches can b

Re: RFC: "SubmittingPatches" text

2000-11-18 Thread Rogier Wolff
Alan Cox wrote: > Maybe also note that maintainers of given modules are much more likely to > give feedback than Linus, also the [PATCH]: convention Question: Should a submitter CC Linus or linux-kernel on the patch before having gotten approval from a maintainer? I'd say DO CC Linux-kernel, d

Re: RFC: "SubmittingPatches" text

2000-11-17 Thread Andries Brouwer
On Fri, Nov 17, 2000 at 09:30:13AM +0100, Kai Germaschewski wrote: > One question comes to my mind: Are patches supposed to be applied with > patch -p0 or patch -p1? Suppose the kernel tree is in /kernpath, starting with /kernpath/linux. Linus' patches can be applied by (cd /kernpath; patch -p0

Re: RFC: "SubmittingPatches" text

2000-11-17 Thread Kai Germaschewski
On Thu, 16 Nov 2000, Jeff Garzik wrote: > To create a patch for a single file, it is often sufficient to do: > > SRCTREE=/usr/src/linux > MYFILE=drivers/net/mydriver.c > > cd $SRCTREE > cp $MYFILE $MYFILE.orig > vi $MYFILE # make your change > diff -u $

Re: RFC: "SubmittingPatches" text

2000-11-16 Thread Peter Samuelson
[Jeff Garzik] > MYSRC=/devel/linux-2.4 > > tar xvfz linux-2.4.0-test11.tar.gz > mv linux linux-vanilla > diff -urN linux-vanilla $MYSRC > /tmp/patch You should use an example where $MYSRC is a single directory level (rather than absolute path) so people can use 'patch -N

Re: RFC: "SubmittingPatches" text

2000-11-16 Thread Gary Lawrence Murphy
Alan and Tigran's comments folded in and Wiki-fied ;) http://kernelbook.sourceforge.net:80/wiki/?PreparingPatches This is not meant to replace the Documentation/... guide, only to provide means for future public contributions. Consider it a tentative preview, not a formal publication, and chan

Re: RFC: "SubmittingPatches" text

2000-11-16 Thread Tigran Aivazian
On Thu, 16 Nov 2000, Alan Cox wrote: > > The Unofficial Linus HOWTO > > 'Care And Operation Of Your Linus Torvalds' > > > > mv linux linux-vanilla > > diff -urN linux-vanilla $MYSRC > /tmp/patch > > Include Tigrans recommended exclude list and info Alan Cox is very concise.

Re: RFC: "SubmittingPatches" text

2000-11-16 Thread Alan Cox
> The Unofficial Linus HOWTO 'Care And Operation Of Your Linus Torvalds' > mv linux linux-vanilla > diff -urN linux-vanilla $MYSRC > /tmp/patch Include Tigrans recommended exclude list and info > code. A MIME attachment also takes Linus a bit more time to process, >

RFC: "SubmittingPatches" text

2000-11-16 Thread Jeff Garzik
I'd like to put the following document into the kernel tree as linux/Documentation/SubmittingPatches, and would like to get comments on it. I've likely left out a lot in Section 2... additions welcome. I don't want to get too domain-specific in section 2, but I would like to cover as many "unwrit