RE: fix suspend/resume irq request free for yenta..

2005-07-25 Thread Brown, Len
>On Sat, Jul 23, 2005 at 02:29:24AM +0200, Pavel Machek wrote: >> > Is it necessary to do free_irq for suspend? Shouldn't disable_irq >> > be enough? >> >> Due to recent changes in ACPI, yes, it is neccessary. > >What if some other driver is sharing the IRQ, and requires IRQs to be >enabled for th

Re: fix suspend/resume irq request free for yenta..

2005-07-24 Thread Russell King
On Sun, Jul 24, 2005 at 08:40:00AM +1000, Dave Airlie wrote: > > > What if some other driver is sharing the IRQ, and requires IRQs to be > > > enabled for the resume to complete? > > All drivers re-enable IRQs on their way back up in their resume code, > they shouldn't be doing anything before tha

Re: fix suspend/resume irq request free for yenta..

2005-07-23 Thread Daniel Ritz
hi the patch is wrong. yenta_request_irq() registers the wrong handler. plus yenta_probe_cb_irq() has nothing to do with suspend/resume (besides it frees the irq in the very same function). correct patch below. somebody cares to explain me why the free_irq() is necessary before a suspend? rgds -

Re: fix suspend/resume irq request free for yenta..

2005-07-23 Thread Dave Airlie
. > > > > What if some other driver is sharing the IRQ, and requires IRQs to be > > enabled for the resume to complete? All drivers re-enable IRQs on their way back up in their resume code, they shouldn't be doing anything before that point.. > This certainly is the case on many laptops. Well at

Re: fix suspend/resume irq request free for yenta..

2005-07-23 Thread Zwane Mwaikambo
On Sat, 23 Jul 2005, Russell King wrote: > On Sat, Jul 23, 2005 at 02:29:24AM +0200, Pavel Machek wrote: > > > Is it necessary to do free_irq for suspend? Shouldn't disable_irq > > > be enough? > > > > Due to recent changes in ACPI, yes, it is neccessary. > > What if some other driver is sharing

Re: fix suspend/resume irq request free for yenta..

2005-07-23 Thread Russell King
On Sat, Jul 23, 2005 at 02:29:24AM +0200, Pavel Machek wrote: > > Is it necessary to do free_irq for suspend? Shouldn't disable_irq > > be enough? > > Due to recent changes in ACPI, yes, it is neccessary. What if some other driver is sharing the IRQ, and requires IRQs to be enabled for the resume

Re: fix suspend/resume irq request free for yenta..

2005-07-22 Thread Pavel Machek
Hi! > > Without this patch my laptop fails to resume from suspend to RAM... > > > > It applies against a pretty recent 2.6.13-rc3 from git.. > > > > Hi, > > Is it necessary to do free_irq for suspend? Shouldn't disable_irq > be enough? Due to recent changes in ACPI, yes, it is neccessary.

Re: fix suspend/resume irq request free for yenta..

2005-07-22 Thread Dmitry Torokhov
On Friday 22 July 2005 17:33, Dave Airlie wrote: > > Without this patch my laptop fails to resume from suspend to RAM... > > It applies against a pretty recent 2.6.13-rc3 from git.. > Hi, Is it necessary to do free_irq for suspend? Shouldn't disable_irq be enough? -- Dmitry - To unsubscribe