Re: __unsafe() usage

2007-07-23 Thread Dan Williams
On 7/23/07, Rusty Russell <[EMAIL PROTECTED]> wrote: On Mon, 2007-07-23 at 19:59 +0200, Adrian Bunk wrote: > On Mon, Jul 23, 2007 at 09:05:54AM -0700, Nelson, Shannon wrote: > > Gabriel C [mailto:[EMAIL PROTECTED] > > > > > >Hi, > > > > > >I got this warning on current git using gcc 4.2.1 : > > >

RE: __unsafe() usage

2007-07-23 Thread Nelson, Shannon
Rusty Russell [mailto:[EMAIL PROTECTED] >> If this is true, and since the MOD_INC_USE_COUNT compat code is long >> gone, shouldn't we be able to completely remove __unsafe() and the >> struct member "unsafe"? > >Yes, indeed, something like this: >== >Remove "unsafe" from module struct > >Adrian

Re: __unsafe() usage

2007-07-23 Thread Rusty Russell
On Mon, 2007-07-23 at 19:59 +0200, Adrian Bunk wrote: > On Mon, Jul 23, 2007 at 09:05:54AM -0700, Nelson, Shannon wrote: > > Gabriel C [mailto:[EMAIL PROTECTED] > > > > > >Hi, > > > > > >I got this warning on current git using gcc 4.2.1 : > > > > > >... > > > > > >drivers/dma/ioatdma.c: In functio