RE: Checkpatch.pl failure

2008-01-14 Thread Salyzyn, Mark
Suppress one of the bogus checkpatch.pl error, the side-effect of the error highlighted that this constant should be replaced by an existing manifest. checkpatch.pl needs to be corrected to accept the comment style to deal with the other cases should they ever be touched by future patches. This

Re: Checkpatch.pl failure

2008-01-14 Thread Andy Whitcroft
On Mon, Jan 14, 2008 at 09:48:53AM -0600, James Bottomley wrote: > This error: > > ERROR: no space before that close parenthesis ')' > #501: FILE: drivers/scsi/dpt_i2o.c:2299: > + if (dev_status == 0x02 /*CHECK_CONDITION*/) { > > Is definitely wrong. I think it's stripped the comme

Re: Checkpatch.pl failure

2008-01-14 Thread Benny Halevy
On Jan. 14, 2008, 17:48 +0200, James Bottomley <[EMAIL PROTECTED]> wrote: > This error: > > ERROR: no space before that close parenthesis ')' > #501: FILE: drivers/scsi/dpt_i2o.c:2299: > + if (dev_status == 0x02 /*CHECK_CONDITION*/) { > > Is definitely wrong. I think it's stripped