RE: Bad DT binding (hisi-pcie-almost-ecam)

2017-03-13 Thread Gabriele Paoloni
nel.org > Subject: Re: Bad DT binding (hisi-pcie-almost-ecam) > > Hi, > > On Mon, Mar 13, 2017 at 08:14:19AM +, Gabriele Paoloni wrote: > > > -Original Message- > > > From: Mark Rutland [mailto:mark.rutl...@arm.com] > > > > The commit add

Re: Bad DT binding (hisi-pcie-almost-ecam)

2017-03-13 Thread Mark Rutland
Hi, On Mon, Mar 13, 2017 at 08:14:19AM +, Gabriele Paoloni wrote: > > -Original Message- > > From: Mark Rutland [mailto:mark.rutl...@arm.com] > > The commit adds the "hisilicon,pcie-almost-ecam", which goes against > > the > > usual DT conventions, and is non-sensical in that it descr

RE: Bad DT binding (hisi-pcie-almost-ecam)

2017-03-13 Thread Gabriele Paoloni
Hi Geert [...] > > { > > - .compatible = "hisilicon,pcie-almost-ecam", > > + .compatible = "hisilicon,pcie-almost-ecam-hip06", > > Shouldn't that be "hisilicon,hip06-pcie-almost-ecam"? > > > + .data = (void *) &hisi_pcie_platform_ops, > > + }, > > +

Re: Bad DT binding (hisi-pcie-almost-ecam)

2017-03-13 Thread Geert Uytterhoeven
On Mon, Mar 13, 2017 at 9:14 AM, Gabriele Paoloni wrote: > About the name to use here from what you suggest we should use > "hisilicon,hip06-pcie-almost-ecam" and re-use it for hip07 SoC. > To be honest I would prefer it either as it is now or to modify the > driver as: > > diff --git a/drivers/pc

RE: Bad DT binding (hisi-pcie-almost-ecam)

2017-03-13 Thread Gabriele Paoloni
Hi Mark > -Original Message- > From: Mark Rutland [mailto:mark.rutl...@arm.com] > Sent: 10 March 2017 17:41 > To: liudongdong (C); Bjorn Helgaas > Cc: Gabriele Paoloni; Wangzhou (B); devicet...@vger.kernel.org; linux- > p...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Bad DT b